adding FB Fetch macros and PLATFORM_SUPPORTS_NATIVE_RENDERPASS #4307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
phi-lira
approved these changes
Apr 28, 2021
Co-authored-by: Felipe Lira <[email protected]>
sebastienlagarde
approved these changes
Apr 29, 2021
|
ABV is green except Update job that was known issue and already fix in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR introduces fb fetch macros that will be needed for implementing input attachments for URP RenderPass work. However, it's more of a core lib thing, so adding it to core package. The macros itself are salvaged from previous Renderpass work PR (#396) with an addition of DXC compiler branches, that was recently introduced
Testing status
Manually hacked the shaders to check if it works. But most proper testing will be done with input attachment PR
Comments to reviewers
Notes for the reviewers you have assigned.