[Yamato] Use choco for Android #4276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 20, 2021 14:26
added 2 commits
April 22, 2021 14:11
This reverts commit 1a540de.
This was referenced Apr 29, 2021
…olatey # Conflicts: # .yamato/script/gfx_sdet_tools_revision.txt
…olatey # Conflicts: # .yamato/shadergraph-android-opengles3.yml # .yamato/shadergraph-android-vulkan.yml # .yamato/universal_hybrid-android-opengles3.yml # .yamato/universal_hybrid-android-vulkan.yml # .yamato/urp_2d-android-opengles3.yml # .yamato/urp_2d-android-vulkan.yml # .yamato/urp_foundation-android-opengles3.yml # .yamato/urp_foundation-android-vulkan.yml # .yamato/urp_lighting-android-opengles3.yml # .yamato/urp_lighting-android-vulkan.yml # .yamato/urp_performance_boatattack-android-opengles3.yml # .yamato/urp_performance_boatattack-android-vulkan.yml # .yamato/urp_performance_lostcrypt-android-opengles3.yml # .yamato/urp_performance_lostcrypt-android-vulkan.yml # .yamato/urp_postpro-android-opengles3.yml # .yamato/urp_postpro-android-vulkan.yml # .yamato/urp_terrain-android-opengles3.yml # .yamato/urp_terrain-android-vulkan.yml # .yamato/vikingvillage_builtin-android-opengles3.yml # .yamato/vikingvillage_builtin-android-vulkan.yml # .yamato/vikingvillage_urp-android-opengles3.yml # .yamato/vikingvillage_urp-android-vulkan.yml
theopnv
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Moves Android to use choco for unity-downloader-cli as the rest of the platforms, since using pip is deprecated.
Testing status
Ran ShaderGraph for both Androids, Viking Village, and Boat Attack
https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/yamato%252Fandroid-chocolatey/.yamato%252Fshadergraph-android-vulkan.yml%2523ShaderGraph_Android_Vulkan_Standalone_il2cpp_Linear_trunk/6439141/job
https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/yamato%252Fandroid-chocolatey/.yamato%252Fshadergraph-android-opengles3.yml%2523ShaderGraph_Android_OpenGLES3_Standalone_cache_il2cpp_Linear_trunk/6396569/job
https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/yamato%252Fandroid-chocolatey/.yamato%252Fvikingvillage_builtin-android-vulkan.yml%2523VikingVillage_BuiltIn_Android_Vulkan_performance_playmode_runtime_il2cpp_Linear_trunk/6525812/job
https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/yamato%252Fandroid-chocolatey/.yamato%252Furp_performance_boatattack-android-vulkan.yml%2523URP_Performance_BoatAttack_Android_Vulkan_performance_playmode_runtime_il2cpp_Linear_trunk/6520839/job (failures match master)
Comments to reviewers
Notes for the reviewers you have assigned.