Enable test 039 for Android/GLES #4269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
OpenGL seems like legit failure? |
Contributor
Author
|
So far I found two issues i
I found two issues in the test scene. Another problem is the custom vertex layout used for the particle system 8 unlit distortion. I think it’s also wrong but only causes problems when instancing is disabled such as on Mali with GLES. |
svens-unity
approved these changes
Apr 29, 2021
Contributor
svens-unity
left a comment
svens-unity
left a comment
There was a problem hiding this comment.
Linking to case for reference: https://fogbugz.unity3d.com/f/cases/1315494
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable test 039 for Android
There were to problems in the test scene:
I found two issues in the test scene.
The red tint happens because a normal map is used as emission texture. So the normal map encoding affects the color.
Another problem is the custom vertex layout used for the particle system 8 unlit distortion. I think it’s also wrong but only causes problems when instancing is disabled such as on Mali with GLES.
I don't know why I didn't have to update the reference image