[2021.2][ShaderGraph] Fixing Gradient node divide by zero warnings #4248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LandonTownsendUnity Do we need to backport this? Only a warning.. behavior is unchanged.. |
julienf-unity
approved these changes
Apr 20, 2021
joshua-davis
approved these changes
Apr 21, 2021
ghost
approved these changes
Apr 21, 2021
cdxntchou
requested review from
marctem
and removed request for
elizabeth-legros
marctem
approved these changes
Apr 28, 2021
|
Tests were green before changelog resolution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Using the sample gradient node results in divide by zero warnings.
This PR fixes the warnings by properly looping over only the active keys.
Testing status
Tested gradient node with 2, 3, 5, 8 keys, checked generated code, visual result and shader warnings.
Yamato:
ShaderGraph PR Job: 🟢
https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/sg%252Ffix-gradient-warnings/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_trunk/6472993/job/pipeline
Comments to reviewers
Notes for the reviewers you have assigned.