[XPipeline]Move Common Camera Drawers and GUIContents to Core. #4228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arttu-peltonen
approved these changes
Apr 20, 2021
Contributor
arttu-peltonen
left a comment
arttu-peltonen
left a comment
There was a problem hiding this comment.
Apart from a few missing API docs, lgtm. I would try to think how to make it more clear what parts "belong" in Core and which should remain in HDRP. Although I'm not familiar with the code so I might be missing something :)
com.unity.render-pipelines.core/Editor/Camera/CameraUI.Output.Drawers.cs
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.core/Editor/Camera/CameraUI.PhysicalCamera.Drawers.cs
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.core/Editor/Camera/CameraUI.Rendering.Drawers.cs
Outdated
Show resolved
Hide resolved
...y.render-pipelines.high-definition/Editor/RenderPipeline/Camera/HDCameraUI.Output.Drawers.cs
Outdated
Show resolved
Hide resolved
RSlysz
requested changes
Apr 20, 2021
Contributor
RSlysz
left a comment
RSlysz
left a comment
There was a problem hiding this comment.
Ok but small fix needed:
- Check static for classes
- Check if sharing Expendable is good in the long therm (I don't have the answear, I just want we don't forget to think of this)
com.unity.render-pipelines.core/Editor/Camera/CameraUI.Output.Skin.cs
Outdated
Show resolved
Hide resolved
| /// <summary> | ||
| /// Environment section | ||
| /// </summary> | ||
| public partial class Environment |
com.unity.render-pipelines.core/Editor/Camera/CameraUI.Environment.Drawers.cs
Outdated
Show resolved
Hide resolved
| /// <summary> | ||
| /// Physical camera related drawers | ||
| /// </summary> | ||
| public partial class PhysicalCamera |
com.unity.render-pipelines.core/Editor/Camera/CameraUI.PhysicalCamera.Skin.cs
Outdated
Show resolved
Hide resolved
...-pipelines.high-definition/Editor/RenderPipeline/Camera/HDCameraUI.PhysicalCamera.Drawers.cs
Show resolved
Hide resolved
...der-pipelines.high-definition/Editor/RenderPipeline/Camera/HDCameraUI.PhysicalCamera.Skin.cs
Show resolved
Hide resolved
...ender-pipelines.high-definition/Editor/RenderPipeline/Camera/HDCameraUI.Rendering.Drawers.cs
Show resolved
Hide resolved
...y.render-pipelines.high-definition/Editor/RenderPipeline/Camera/HDCameraUI.Rendering.Skin.cs
Show resolved
Hide resolved
Comment on lines
+10
to
+26
| public enum Expandable | ||
| { | ||
| /// <summary> Projection</summary> | ||
| Projection = 1 << 0, | ||
| /// <summary> Physical</summary> | ||
| Physical = 1 << 1, | ||
| /// <summary> Output</summary> | ||
| Output = 1 << 2, | ||
| /// <summary> Orthographic</summary> | ||
| Orthographic = 1 << 3, | ||
| /// <summary> RenderLoop</summary> | ||
| RenderLoop = 1 << 4, | ||
| /// <summary> Rendering</summary> | ||
| Rendering = 1 << 5, | ||
| /// <summary> Environment</summary> | ||
| Environment = 1 << 6, | ||
| } |
Contributor
There was a problem hiding this comment.
Just a small concern here now that we share the Expendable:
- does every SRP will always have the same Area?
- Though as registration of expendable state is done in HDRP camera, the collapsing of lets say Projection area only collapse Projection for HDRP Camera and not for all (URP, CustomRP). Is this what we want? Should we also have a shared expendable state? What is expected to be done when making a custom SRP now regarding this change ?
Contributor
Author
There was a problem hiding this comment.
URP will have an extra expandable state here that will be Stack, I will add it on the future. The expanded state isn't shared. Maybe we can share it, it will be an option.
A custom SRP could have it's own store for it expandables. The thing here is we are letting SRP to use this sections, if they want to use it is on their hands.
Contributor
Author
|
@Unity-Technologies/gfx-qa-hdrp could you please do a full test on camera inspector? Check that everything is updated properly, and check that the fields are the same as previous versions. |
RSlysz
approved these changes
Apr 26, 2021
iM0ve
approved these changes
Apr 26, 2021
Contributor
iM0ve
left a comment
iM0ve
left a comment
There was a problem hiding this comment.
Whats tested:
- Upgrading Amalienborg project and empty project
- Checked preconfigured cameras still function as expected (Night, Evening, Afternoon)
- Tested all properties found on camera to see that they still work
- Checked volumes that have the ability to Use Physical Camera (Exposure and Depth of Field), can still be linked and utilize physical camera properties.
- Verified you can still save changes for cameras. Changed a value and restarted the editor to see its still set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
JIRA
Moving all the drawers shared with URP to Core.
No user facing changes, added new public API, that can be usefull for Custom SRP's
Testing status
Check the Camera Inspector works in the same way.
Comments to reviewers
Mainly moving code arround to Core.