Skip to content

[Universal] MSAA store actions optimizations for forward renderer Drawobjects pass #4161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Apr 28, 2021
Merged

[Universal] MSAA store actions optimizations for forward renderer Drawobjects pass #4161

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
b4b6edf
initial store and load action SRP support
manuele-bonanno Apr 7, 2021
5c53798
removed depth prepass related temporary changes
manuele-bonanno Apr 8, 2021
6233c18
removing commented out code
manuele-bonanno Apr 8, 2021
1a77378
removing unused variables
manuele-bonanno Apr 8, 2021
03504e3
Added Store Actions settings
manuele-bonanno Apr 12, 2021
a6f59ed
moved the code that checks for injected passes
manuele-bonanno Apr 13, 2021
af2ecba
cleanup and addressing reviewer's feedback
manuele-bonanno Apr 13, 2021
1a9ce7f
Merge branch 'master' into urp/msaa_store_actions_optimization
manuele-bonanno Apr 13, 2021
1ee51a6
moved the "Store Actions" setting in the Advanced options section
manuele-bonanno Apr 13, 2021
8e95a89
further depth store action optimization for when MSAA is disabled
manuele-bonanno Apr 13, 2021
f2e7ec3
Added changelog entry
manuele-bonanno Apr 13, 2021
cc6422b
Added documentation
manuele-bonanno Apr 13, 2021
0b2d3a1
handling the opaque pass depth store actions separately for a more op…
manuele-bonanno Apr 14, 2021
701f703
Merge branch 'master' into urp/msaa_store_actions_optimization
manuele-bonanno Apr 15, 2021
f07f748
if "Store Actions"=Store, make sure to preserve and StoreAndResolve a…
manuele-bonanno Apr 15, 2021
de91e70
addressed reviewers feedback
manuele-bonanno Apr 16, 2021
060261b
added new API docs as requested by reviewers
manuele-bonanno Apr 16, 2021
cd25137
Added storeActionsOptimization property setter after reviewer's feedback
manuele-bonanno Apr 16, 2021
1bd8a24
the opaqueColorStoreAction should be StoreAndResolve only if copy col…
manuele-bonanno Apr 16, 2021
4e300f6
renamed parameter of CoreUtils.SetRenderTarget after reviewer's feedback
manuele-bonanno Apr 19, 2021
9761545
updated the tooltip after reviewer's feedback
manuele-bonanno Apr 19, 2021
887eb25
Merge branch 'master' into urp/msaa_store_actions_optimization
manuele-bonanno Apr 20, 2021
6b1315f
removed using System.ComponentModel.Design.Serialization; line added …
manuele-bonanno Apr 21, 2021
facbf42
removing files accidentally added by a previous merge
manuele-bonanno Apr 21, 2021
507291d
Edited the __Store Actions__ description.
oleks-k Apr 26, 2021
71e9011
Edited the StoreActionsOptimization API descriptions.
oleks-k Apr 26, 2021
b46f66a
Merge branch 'master' into urp/msaa_store_actions_optimization
manuele-bonanno Apr 26, 2021
23694e6
Merge branch 'master' into urp/msaa_store_actions_optimization
manuele-bonanno Apr 27, 2021
39b1394
editor test fix
manuele-bonanno Apr 27, 2021
497777f
Merge branch 'master' into urp/msaa_store_actions_optimization
phi-lira Apr 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added TestProjects/UniversalGraphicsTest/Assets/Scenes/005_LitBakedEmission/LightingData.asset
View file
Open in desktop
Binary file not shown.
8 changes: 8 additions & 0 deletions ...Projects/UniversalGraphicsTest/Assets/Scenes/005_LitBakedEmission/LightingData.asset.meta
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file added ...ojects/UniversalGraphicsTest/Assets/Scenes/005_LitBakedEmission/Lightmap-0_comp_light.exr
View file
Open in desktop
Binary file not shown.
96 changes: 96 additions & 0 deletions ...s/UniversalGraphicsTest/Assets/Scenes/005_LitBakedEmission/Lightmap-0_comp_light.exr.meta
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file added TestProjects/UniversalGraphicsTest/Assets/Scenes/007_LitShaderMaps/LightingData.asset
View file
Open in desktop
Binary file not shown.
8 changes: 8 additions & 0 deletions TestProjects/UniversalGraphicsTest/Assets/Scenes/007_LitShaderMaps/LightingData.asset.meta
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions ...s/UniversalGraphicsTest/Assets/Scenes/007_LitShaderMaps/Lightmap-0_comp_dir.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
96 changes: 96 additions & 0 deletions ...ojects/UniversalGraphicsTest/Assets/Scenes/007_LitShaderMaps/Lightmap-0_comp_dir.png.meta
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file added TestProjects/UniversalGraphicsTest/Assets/Scenes/007_LitShaderMaps/Lightmap-0_comp_light.exr
View file
Open in desktop
Binary file not shown.
96 changes: 96 additions & 0 deletions ...ects/UniversalGraphicsTest/Assets/Scenes/007_LitShaderMaps/Lightmap-0_comp_light.exr.meta
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file added ...niversalGraphicsTest/Assets/Scenes/017_Lighting_Scene_DirectionalBaked/LightingData.asset
View file
Open in desktop
Binary file not shown.
8 changes: 8 additions & 0 deletions ...salGraphicsTest/Assets/Scenes/017_Lighting_Scene_DirectionalBaked/LightingData.asset.meta
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file added ...lGraphicsTest/Assets/Scenes/017_Lighting_Scene_DirectionalBaked/Lightmap-0_comp_light.exr
View file
Open in desktop
Binary file not shown.
Loading