Skip to content

Conversation

@phi-lira
Copy link
Contributor

@phi-lira phi-lira commented Apr 8, 2021

Purpose of this PR

This PR creates a URP graphics test package. This is useful for two reasons:

  • we don't duplicate scripts and assets between test projects
  • the package has the graphics test framework dependency so other teams / packages can integrate test with URP by adding the URP graphics test package.

Testing status

  • Run tests locally.

Comments to reviewers

  • Common assets and scripts were moved to the new graphics test package.
  • Each split project references the new graphics test package.
  • I could see some issues / warning in the test projects but they didn't seem related to my changes so I plan to fix them in follow PR.

@github-actions
Copy link

github-actions bot commented Apr 8, 2021

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page)
and cancel any jobs that started on Yamato.
See the PR template for more information.
Thank you!

@phi-lira phi-lira requested a review from hdb-unity April 8, 2021 15:42
@amechtley amechtley mentioned this pull request Apr 9, 2021
@phi-lira
Copy link
Contributor Author

Closing. Next iteration #4182

@phi-lira phi-lira closed this Apr 14, 2021
@phi-lira phi-lira deleted the universal/test-package branch April 14, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants