Universal converter / upgrader framework #4103

martint-unity · 2021-04-07T13:30:08Z

Purpose of this PR

To create a UI and an API for adding and creating converters. These converters will help us convert projects form Built-in to URP.
This framework is mainly how to create a converter and show the data in the converter UI.
We need to have a robust and easily extendable system in which other people can make upgraders easily and use this UI/UX workflow. If another team wants to make an upgrader for GI-Bake (example) then they should easily be able to add that to this workflow.

This is how the UI looks now

It is not finished.

This draft PR is for the API.
Users should be able to use this and create converters.

QA:
Added the material Converter in this PR so that we have something to test. So would be good to test that on an older project. Upgrading materials. You will also need a Script define to get the tool to show. Talk to @martin-unity3d to get this setup?

The UI is not finished (will be addressed in later PR's) and if there are feedback on it then we have another document for that. again talk to @martin-unity3d to get access to that document.

Release Management Epic UR-2029

removed list to the convert method. removed the return och list struct. Instead the converter owns those items now.

Made the bindings to the UI and the saved properties

Added category to converter class Added which converstion stage the converter is in, like Builit-in to URP, Built-in To HDRP or your own converstion stage.

moved Converter Core to Core RP folder

Added functionality for disabling a converter added methods for marking items for failurs or success

that is called when switching item in the list of converter items.

made so that the icons get updated accordingly

Made a small border added padding. removed a visual element

Tested contextual menu for list view items

…-framework # Conflicts: # TestProjects/UniversalGraphicsTest_PostPro/Assets/Editor/Converter.meta # TestProjects/UniversalGraphicsTest_PostPro/Assets/Editor/Converter/Widget.meta # TestProjects/UniversalGraphicsTest_PostPro/Assets/Editor/Converter/Widget/converter_widget.uss # TestProjects/UniversalGraphicsTest_PostPro/Assets/Editor/Converter/Widget/converter_widget.uss.meta # TestProjects/UniversalGraphicsTest_PostPro/Assets/Editor/Converter/Widget/converter_widget.uxml # TestProjects/UniversalGraphicsTest_PostPro/Assets/Editor/Converter/Widget/converter_widget.uxml.meta # TestProjects/UniversalGraphicsTest_PostPro/Assets/Editor/Converter/Widget/converter_widget_item.uxml # TestProjects/UniversalGraphicsTest_PostPro/Assets/Editor/Converter/Widget/converter_widget_item.uxml.meta # TestProjects/UniversalGraphicsTest_PostPro/Assets/Editor/Converter/converter_editor.uss # TestProjects/UniversalGraphicsTest_PostPro/Assets/Editor/Converter/converter_editor.uss.meta # TestProjects/UniversalGraphicsTest_PostPro/Assets/Editor/Converter/converter_editor.uxml # TestProjects/UniversalGraphicsTest_PostPro/Assets/Editor/Converter/converter_editor.uxml.meta

com.unity.render-pipelines.core/Editor/RenderPipelineConversion.cs

com.unity.render-pipelines.core/Editor/RenderPipelineConverter.cs

alex-vazquez

Some minor comments

com.unity.render-pipelines.core/Editor/Converter/ConverterItemDescriptor.cs

com.unity.render-pipelines.core/Editor/Converter/ConverterItemInfo.cs

com.unity.render-pipelines.core/Editor/Converter/RunConverterContext.cs

com.unity.render-pipelines.core/Editor/Converter/RenderPipelineConverter.cs

com.unity.render-pipelines.core/Editor/Converter/RenderPipelineConvertersEditor.cs

…-framework # Conflicts: # com.unity.render-pipelines.core/Editor/CoreEditorStyles.cs

Added name space change variable names on VisualElements Assets commented choices code

phi-lira

LGTM, minor comments.
I think we also discussed that the upgrader/converter would not expose public API until we are confident with a couple of usages to mature API?

If so, then let's make converter API internal for now until we are confident to share a nice API to users.

com.unity.render-pipelines.universal/Editor/BuiltInToURPConverterContainer.cs

com.unity.render-pipelines.core/Editor/MaterialUpgrader.cs

Removed public accessor for methods in material upgrader

pbbastian

Mostly looks good, have some comments. com.unity.render-pipelines.universal/Editor/Converter/converter_widget.uss is empty and should be removed.

com.unity.render-pipelines.universal/Editor/Converter/RenderPipelineConverter.cs

com.unity.render-pipelines.universal/Editor/Converter/RenderPipelineConverterContainer.cs

com.unity.render-pipelines.universal/Editor/Converter/RenderPipelineConvertersEditor.cs

Removed the sace to layout method. Fixed a bug regarding UI reloading

com.unity.render-pipelines.universal/Editor/Converter/RenderPipelineConverter.cs

…-framework

erikabar

Tested if old functionality of material upgrader works with several different built-in projects, everything works smoothly, no regressions found.

phi-lira · 2021-04-29T06:41:05Z

Failures are known issues, or jobs that we cancelled because they don't affect this PR.

martint-unity added 30 commits March 3, 2021 09:01

initial commit for the uxml's

a8b3c1c

updates to widget

0649efa

update to uxml for editor part

a6c66c9

updates to layout

fe60e22

Added first init of coonverters

9944ab2

Updated styling and added new converter item

6cf0c4b

Added convert method and restructured code

f244127

removed list to the convert method. removed the return och list struct. Instead the converter owns those items now.

added test converters. will be removed before done

4e8b454

Added converter Context

d4b4c61

Made the widget root element Bindable

d4c1432

Made the bindings to the UI and the saved properties

Moved code into init phase

8c11fbe

updates to the bindings to the Serilized Object

38c9cb9

Updated the naming of core converter

650b811

Added category to converter class Added which converstion stage the converter is in, like Builit-in to URP, Built-in To HDRP or your own converstion stage.

Made sure user doesnt init twize

8d364aa

moved Converter Core to Core RP folder

moved the uxml's and uss to core and the Editor

d8890e9

spring cleaning

df2b186

Updated the converter UI to get errors and pending

de3165d

Added functionality for disabling a converter added methods for marking items for failurs or success

Added OnClicked method

5f3b773

that is called when switching item in the list of converter items.

added status enum

16f7d92

made so that the icons get updated accordingly

updated the ui a bit

7986ca8

Made a small border added padding. removed a visual element

changed icon size and removed Visual element

c02175e

Added contextual menu, but commented it out

6669e06

Added active bool to converteritemstate

a5116c7

Tested contextual menu for list view items

oups, active bool was placed in the wrong statment

366d835

Added manipulator, trying out userData for index

faca1ea

cleaned out and documented code

6437db9

fixed a small bug in init method and list refresh

b532a7e

Removed unnecessary files

0836acc

added some doc strings

e2710cd

pbbastian suggested changes Apr 12, 2021

View reviewed changes

martint-unity added 5 commits April 13, 2021 16:58

PR feedback, split code into files

bfbb0ae

added progressbar and material upgrader

0c9fcd8

Spring cleaning

4ecc880

Moved code into folder

f88c9bf

New name for Conversion, changed to Container

e4230a6

alex-vazquez reviewed Apr 19, 2021

View reviewed changes

martint-unity added 3 commits April 20, 2021 13:58

Updated with PR feedback and Doc strings

43bf46a

Merge branch 'master' into universal/upgrader/builtin-to-urp-upgrader…

3f7d115

…-framework # Conflicts: # com.unity.render-pipelines.core/Editor/CoreEditorStyles.cs

Adressed PR feedback

689e1ee

Added name space change variable names on VisualElements Assets commented choices code

martint-unity requested review from a team and pbbastian April 21, 2021 08:00

phi-lira approved these changes Apr 21, 2021

View reviewed changes

martint-unity added 3 commits April 22, 2021 10:47

Addressed PR Feedback. Changed message string

b9198c1

Moved converter to URP package.

a958cac

Removed public accessor for methods in material upgrader

Made converter and container internal

c1efeeb

erikabar self-requested a review April 26, 2021 08:33

martint-unity marked this pull request as ready for review April 26, 2021 09:43

martint-unity requested a review from a team as a code owner April 26, 2021 09:43

pbbastian suggested changes Apr 26, 2021

View reviewed changes

Adressed PR feedback

ae5083c

Removed the sace to layout method. Fixed a bug regarding UI reloading

pbbastian suggested changes Apr 27, 2021

View reviewed changes

com.unity.render-pipelines.universal/Editor/Converter/RenderPipelineConverter.cs Outdated Show resolved Hide resolved

Removed member var, returned true instead

2516c9d

pbbastian approved these changes Apr 27, 2021

View reviewed changes

Merge branch 'master' into universal/upgrader/builtin-to-urp-upgrader…

a28bebe

…-framework

erikabar approved these changes Apr 28, 2021

View reviewed changes

phi-lira merged commit b60ac12 into master Apr 29, 2021

phi-lira deleted the universal/upgrader/builtin-to-urp-upgrader-framework branch April 29, 2021 06:41

Universal converter / upgrader framework #4103

Universal converter / upgrader framework #4103

Uh oh!

Conversation

martint-unity commented Apr 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose of this PR

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alex-vazquez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

phi-lira left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pbbastian left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erikabar left a comment

Choose a reason for hiding this comment

Uh oh!

phi-lira commented Apr 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

martint-unity commented Apr 7, 2021 •

edited

Loading