Skip to content

Fix for NaN that can happen on area lights at a certain angle. #4081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2021
Merged

Fix for NaN that can happen on area lights at a certain angle. #4081

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
280fe14
Fix NaN with V1oV2 == -1
FrancescoC-unity Apr 6, 2021
23a14b7
Changelog
FrancescoC-unity Apr 6, 2021
8c38840
Use clamping instead
FrancescoC-unity Apr 6, 2021
0cca9dd
Merge branch 'hd/bugfix' into HDRP/fix-NaN-in-area-light
sebastienlagarde Apr 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion com.unity.render-pipelines.core/ShaderLibrary/AreaLighting.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ real3 ComputeEdgeFactor(real3 V1, real3 V2)
if (V1oV2 < 0)
{
// Undo range reduction.
y = PI * rsqrt(saturate(1 - V1oV2 * V1oV2)) - y;
const float epsilon = 1e-5f;
y = PI * (max(epsilon, saturate(1 - V1oV2 * V1oV2))) - y;
}

return V1xV2 * y;
Expand Down
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed a bug with Reflection Probe baking would result in an incorrect baking reusing other's Reflection Probe baking
- Fixed volumetric fog being visually chopped or missing when using hardware Dynamic Resolution Scaling.
- Fixed generation of the packed depth pyramid when hardware Dynamic Resolution Scaling is enabled.
- Fixed a NaN generating in Area light code.

### Changed
- Changed Window/Render Pipeline/HD Render Pipeline Wizard to Window/Rendering/HDRP Wizard
Expand Down