Skip to content

Conversation

@nerites
Copy link
Contributor

@nerites nerites commented Apr 1, 2021

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

Backport of #3911
10.x.x PR: #3861


Testing status

Opened with 2021.1/staging and confirmed shadergraphs work. Need QA pass technically


Comments to reviewers

@github-actions github-actions bot added the SRP label Apr 1, 2021
@nerites nerites changed the title Add SpeedTree8 shadergraph to HD and Universal [2021.1] Add SpeedTree8 shadergraph to HD and Universal Apr 1, 2021
@nerites nerites marked this pull request as ready for review April 5, 2021 16:26
@nerites nerites requested review from a team as code owners April 5, 2021 16:26
@nerites nerites requested a review from a team as a code owner April 6, 2021 20:44
@phi-lira phi-lira requested a review from ellioman April 8, 2021 06:47
@nerites nerites requested a review from ValGrimm-U3D April 14, 2021 16:18
Copy link
Contributor

@ValGrimm-U3D ValGrimm-U3D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for responding to my many questions and suggestions, fine to merge. 👍

@nerites nerites force-pushed the 2021.1/speedtreesg branch from eca4c3d to bce8c6a Compare April 16, 2021 22:28
Copy link
Contributor

@JMargevics JMargevics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as with other backport. All issues discussed, approving ✅

@Jonasmortensen Jonasmortensen self-requested a review April 26, 2021 07:27
Copy link
Contributor

@erikabar erikabar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do not have QA bandwidth right now, we will test this after feature cutoff.

Copy link
Contributor

@erikabar erikabar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with a scene with a few SpeedTrees with SpeedTree8_PBRLit shadergraph, everything works as expected in the Editor and Standalone build. Also tested Wind Zone, Terrain Tree painting, interaction with Spot, Point, Directional lights - no issues found.
There is one issue on Metal - 4 warnings are thrown in the shadergraph:
image

@phi-lira phi-lira merged commit 87b79eb into 2021.1/staging Jun 3, 2021
@phi-lira phi-lira deleted the 2021.1/speedtreesg branch June 3, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants