-
Notifications
You must be signed in to change notification settings - Fork 858
[2021.1] Add SpeedTree8 shadergraph to HD and Universal #4068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ValGrimm-U3D
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for responding to my many questions and suggestions, fine to merge. 👍
eca4c3d to
bce8c6a
Compare
JMargevics
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comments as with other backport. All issues discussed, approving ✅
erikabar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we do not have QA bandwidth right now, we will test this after feature cutoff.
erikabar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with a scene with a few SpeedTrees with SpeedTree8_PBRLit shadergraph, everything works as expected in the Editor and Standalone build. Also tested Wind Zone, Terrain Tree painting, interaction with Spot, Point, Directional lights - no issues found.
There is one issue on Metal - 4 warnings are thrown in the shadergraph:

Please read the Contributing guide before making a PR.
Checklist for PR maker
need-backport-*label. After you backport the PR, the label changes tobackported-*.CHANGELOG.mdfile.Purpose of this PR
Backport of #3911
10.x.x PR: #3861
Testing status
Opened with 2021.1/staging and confirmed shadergraphs work. Need QA pass technically
Comments to reviewers