Skip to content

Conversation

@NetteVI
Copy link
Contributor

@NetteVI NetteVI commented Mar 30, 2021

Purpose of this PR

Continuation of #3949

The Desktop Graphic team is evaluating the graphic tests that are currently disabled in an effort to support the SRP teams through fixing issues that maybe occurring in the graphic device layer. The list of disabled tests and their status can be found in the following google sheets:
URP: https://docs.google.com/spreadsheets/d/1NK3J0DIqiQTCjDaYsD5h2zuftML0e-s8/edit#gid=543321773
HDRP: https://docs.google.com/spreadsheets/d/11iY_cbOn9Mt1jba24295RU5zAnEAay1h/edit#gid=1152131761

This PR enables with no code changes:

  • URP 035_Shader_TerrainShaders (OpenGL, DX11, DX12 - was previously fixed with https://fogbugz.unity3d.com/f/cases/1304675)
  • HDRP 1501_EyeTestSG (Metal)
  • HDRP 1703_Decals-ReorientedNormals (Metal)
  • HDRP 2003_Light_Parameters (Metal)
  • HDRP 2204_ReflectionProbes_Lights (Vulkan)
  • HDRP 2205_LightLoopCullWOblique (Metal)
  • HDRP 2209_ReflectionProbeCullingStencil (Metal)
  • HDRP 2401_Area_Light_Meshes (Metal)
  • HDRP 2403_Area_TexturedRectLights (Metal)
  • HDRP 2404_Area_LightOrientation (Metal)

Enables with template image updates:

  • URP 035_Shader_TerrainShaders (Vulkan)
  • HDRP 1303_StackLitSG_Testers_a, 1303_StackLitSG_Testers_b (Metal)
  • HDRP 2402_Area_Rect_Shadow (Metal)

Enables with changes:

  • URP 126_RendererFeatureActive (All platforms, just needed to re-select the renderer asset after previous cleanup PRs)

Testing status

Ran Yamato URP and HDRP PR jobs multiple times, ran URP Foundations multiple times to check test 126 stability.
Looks like there's an unrelated issue with some iPhone URP jobs.


Comments to reviewers

Notes for the reviewers you have assigned.

@sebastienlagarde sebastienlagarde marked this pull request as ready for review April 27, 2021 08:34
@sebastienlagarde sebastienlagarde merged commit 4486ce8 into master Apr 27, 2021
@sebastienlagarde sebastienlagarde deleted the tests/enable3 branch April 27, 2021 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants