Skip to content

Conversation

@unity-cchu
Copy link
Contributor

@unity-cchu unity-cchu commented Mar 26, 2021

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.

Purpose of this PR

To improve the usability of Pixel Perfect. This does not add new functionality but rather improves existing functionality.


Testing status

I have run it through automated test scenes setup and made sure they upgrade properly.

@unity-cchu unity-cchu requested a review from a team April 6, 2021 04:19
@BoonKiangTan
Copy link

Fixes verified on branch:

Version: 2021.2.0a10.1508
Revision: trunk b8c2bb7e8b36
Built: Tue, 16 Mar 2021 16:54:50 GMT
Package branch: 2d/Pixel-Perfect-Improvements (4b8a974)

  • Verified Camera Projection and the Camera Size properties are disabled in Camera component if URP Pixel Perfect Camera component is added (Verified warning box appears to inform users)
  • Verified Pixel Perfect Camera error message in inspector if no SRP/non-2D URP asset is added to Project Settings > Graphics
  • Verified “Windowbox” Crop Frame mode visual artifacts are fixed (Black bars appear around camera view when Windowbox is selected)
  • “Letterbox” Crop Frame issue, and by extension, Windowbox and Stretchfill resolution issues are fixed

@unity-cchu unity-cchu marked this pull request as ready for review April 13, 2021 07:18
@unity-cchu unity-cchu requested review from a team as code owners April 13, 2021 07:18
@unity-cchu unity-cchu marked this pull request as draft April 15, 2021 08:04
@unity-cchu unity-cchu marked this pull request as ready for review April 15, 2021 08:04
@phi-lira phi-lira added the 2d label Apr 22, 2021
@phi-lira
Copy link
Contributor

LGTM. @TheoWong-pixel could review UX.

@TheoWong-pixel
Copy link

TheoWong-pixel commented Apr 22, 2021

Want to confirm: that it is a warning box or Info box? I believe in @Xiangtingsu's design it is supposed to be an info box which i agree with.

can we also get some images to confirm the disabling please?

@unity-cchu
Copy link
Contributor Author

unity-cchu commented Apr 26, 2021

image

image

@unity-cchu unity-cchu marked this pull request as draft April 27, 2021 08:12
@unity-cchu unity-cchu marked this pull request as ready for review April 27, 2021 08:12
@unity-cchu unity-cchu merged commit 523410d into master Apr 29, 2021
@unity-cchu unity-cchu deleted the 2d/Pixel-Perfect-Improvements branch April 29, 2021 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants