Skip to content

[HDRP] Disc light realtime gi UI error #3866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebastienlagarde merged 2 commits into from
Mar 16, 2021
Merged

[HDRP] Disc light realtime gi UI error #3866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d0cb5a
Added an error in the UI when trying to use disk lights with realtime GI
Mar 15, 2021
0aef728
Updated changelog
Mar 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Added a Falloff Mode (Linear or Exponential) in the Density Volume for volume blending with Blend Distance.
- Added support for screen space shadows (directional and point, no area) for shadow matte unlit shader graph.
- Added support for volumetric clouds in planar reflections.
- Added an error message when trying to use disk lights with realtime GI (case 1317808).

### Fixed
- Fixed Intensity Multiplier not affecting realtime global illumination.
Expand Down
3 changes: 3 additions & 0 deletions com.unity.render-pipelines.high-definition/Editor/Lighting/HDLightUI.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,9 @@ static void DrawGeneralContent(SerializedHDLight serialized, Editor owner)
case AreaLightShape.Disc:
if (!serialized.settings.isCompletelyBaked)
EditorGUILayout.HelpBox("Disc Area Lights are baked only.", MessageType.Error);
// Disc lights are not supported in Enlighten
if (!Lightmapping.bakedGI && Lightmapping.realtimeGI)
EditorGUILayout.HelpBox("Disc Area Lights are not supported with realtime GI.", MessageType.Error);
break;
}
}
Expand Down