[2020.2][VFX] Fix 1300320 - Infinite compilation loop #3500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
julienf-unity
changed the title
julienf-unity
changed the title
|
Hi, here's the Test Doc. Thank you for fixing this nasty bug, although found a few issues that could be looked into |
|
The issue Vlad found regarding changing settings of disabled blocks recompilation is also reproducible on 2020.2. Could this be fixed in 2020.2 too? Test Doc |
VitaVFX
approved these changes
Feb 24, 2021
VitaVFX
left a comment
VitaVFX
left a comment
There was a problem hiding this comment.
Looks good, haven't find any other issues!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Backport 2020.2 of #3498
Fix for https://fogbugz.unity3d.com/f/cases/1300320/
Testing status
Tested locally
Comments to reviewers
HUP bug