Hd/fix backplate globalcubemap2 #3111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ally work conceptually and caused artefacts.
|
It appears that you made a non-draft PR! |
sebastienlagarde
approved these changes
Jan 18, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a recreation of #3090 and has already been reviewed
Purpose of this PR
This PR removes rendering of backplates inside the cubemap generated for lightng in the HDRI sky.
The reason is that it did not make sense conceptually since the backplate needs a position and the cubemap is rendered at infinity. This caused artefacts in reflections coming from the sky cubemap.
This will fix https://fogbugz.unity3d.com/f/cases/1276692/
Testing status
Tested the repro scene provided in the case.
@Unity-Technologies/gfx-qa-hdrp it could be good to test a bit more thoroughly the backplate feature as I'm not 100% familiar with it so I might have missed some cases. Also please test local reflection probes. They should still contain the backplate.