[Yamato] Enable cache server for standalone build jobs #3106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophiaaar
changed the title
added 3 commits
January 14, 2021 16:36
need to wrap each string around "extra-editor-arg"
theopnv
approved these changes
Jan 14, 2021
Contributor
Author
|
formatting failures are unrelated to this PR - started occurring when in merged in master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Example of timing difference:
URP build for Windows DX11 before cache server = 2 hours
After cache server 20 minutes
Testing status
Ran ABV twice to ensure jobs were quicker
Some of the commands contained spaces which didn't work for UNIX platforms, meaning theyd get the error
Cache server is enabled, but endpoint string is not valid: ''Before fix: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/yamato%252Fcache-server-builds/.yamato%252Funiversal-linux-vulkan.yml%2523Build_Universal_Linux_Vulkan_Standalone_cache_mono_Linear_trunk/4890267/job
After fix: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/yamato%252Fcache-server-builds/.yamato%252Funiversal-linux-vulkan.yml%2523Build_Universal_Linux_Vulkan_Standalone_cache_mono_Linear_trunk/4891973/job
Comments to reviewers
Failures appear to match master