Skip to content

[9.x.x][URP] Use Back Buffer for Camera Stacking tests #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 81 commits into from
Apr 30, 2020
Merged

[9.x.x][URP] Use Back Buffer for Camera Stacking tests #255

merged 81 commits into from
Apr 30, 2020

Conversation

@sophiaaar
Copy link
Contributor

@sophiaaar sophiaaar commented Apr 24, 2020 •
edited
Loading

Purpose of this PR

  • This PR enables the Universal camera stacking tests following the update to the graphics test framework
  • Turns on the camera stacking tests (119, 123, 124, 125)
  • Filters out the camera stacking tests on OSX Standalone due to issues with the VM software

Testing status

Manual Tests: What did you do?

  • Opened test project + Run graphic tests locally
  • Built a player
  • Other:

Automated Tests:
Tests added to the Graphics Test Framework (see linked PR at bottom)

Yamato:
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/tests%252Fuse-back-buffer

Comments to reviewers

Graphics test framework version 7.2.0-preview needs to be promoted before this will work
https://github.cds.internal.unity3d.com/unity/com.unity.testframework.graphics/pull/30

sophia and others added 30 commits February 28, 2020 14:05
Shader Graph back buffer tests
075e2d1
@sophiaaar
Merge branch 'master' into tests/use-back-buffer
c713afc
@sophiaaar
Fix camera stacking tests
6cd92c0
@sophiaaar
Merge branch 'master' into tests/use-back-buffer
298cfab
@sophiaaar
Update manifest.json
b81eb3d
@sophiaaar
revert before landing
9d7bf07
@sophiaaar
update reference images
5681677
@sophiaaar
update scenes
e6db9e3
@sophiaaar
Update 119_CameraToRTWithViewportRect.png
7d526e7
@sophiaaar
update reference images
809c77c
@sophiaaar
update 119 osxplayer
dee1214
@sophiaaar
increase waitframes
d664a0a
adust threshold for 119
1ad7e64
Update ProjectSettings.asset
2aec9f7
move components to maincamera
1b264d5
Update manifest.json
949711a
Update manifest.json
76740d1
Update manifest.json
f4917af
Update manifest.json
b7e708d
Update manifest.json
fe5a829
Update manifest.json
0098c31
force the screen resolution
8e6167e
Create Unity.ps1
cb0799a
change dpi on mac
4b6b1f3
remove skip checkout
d6ace32
Merge branch 'master' into tests/use-back-buffer
a8adcbe
dot source powershell script
d3d37d5
Update 125_CameraStackingVolumes.png
ed6118d
put the mac resolution change in the correct job this time
22795df
change res on vm, not device
afcf7e1
@sophiaaar sophiaaar changed the title Tests/use back buffer [9.x.x][URP] Use Back Buffer for Camera Stacking tests Apr 28, 2020
@sophiaaar sophiaaar marked this pull request as ready for review April 28, 2020 11:46
@sophiaaar sophiaaar requested a review from a team as a code owner April 28, 2020 11:46
@sophiaaar sophiaaar requested a review from a team April 29, 2020 08:29
@sophiaaar
Copy link
Contributor Author

sophiaaar commented Apr 30, 2020

The shader graph tests are broken in master and are unrelated to this PR

@sophiaaar sophiaaar merged commit 61dc0c0 into master Apr 30, 2020
@sophiaaar sophiaaar deleted the tests/use-back-buffer branch April 30, 2020 15:27
sophiaaar added a commit that referenced this pull request May 1, 2020
@sophiaaar
backport #255
e681082
@sophiaaar sophiaaar mentioned this pull request May 1, 2020
Merged
sophiaaar added a commit that referenced this pull request May 6, 2020
@sophiaaar
[8.x.x][URP][Backport] Camera stacking tests (#343)
75644fd 
* backport #255

* Create 124_CameraStackingClearRT.png.meta

* [9.x.x][URP] Add/update reference images for android (#341)
@ellioman
Copy link
Contributor

ellioman commented Sep 1, 2020

This PR was also backported to 7.x.x in #563

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ellioman ellioman ellioman approved these changes

@stramit stramit stramit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backported-7.x backported-8.x testing universal yamato

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sophiaaar @ellioman @stramit