[Universal|Bugfix] Bloom is over bright when used in Gammaspace #2513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brings bloom closer aligned between linear and gamma colourspaces
stramit
approved these changes
Nov 3, 2020
phi-lira
approved these changes
Nov 4, 2020
simon-engelbrecht-soerensen
requested review from
simon-engelbrecht-soerensen
and removed request for
a team
simon-engelbrecht-soerensen
approved these changes
Nov 5, 2020
simon-engelbrecht-soerensen
left a comment
simon-engelbrecht-soerensen
left a comment
There was a problem hiding this comment.
Working as expected - bloom values are similar on linear and gamma with template, polygon farm and boat attack. And with DX11/Vulkan/OpenGLCore API's.
Chman
approved these changes
Nov 10, 2020
Verasl
added a commit
that referenced
this pull request
Nov 10, 2020
* Removing some gamma space only code brings bloom closer aligned between linear and gamma colourspaces * Added changelog # Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md
Verasl
added a commit
that referenced
this pull request
Nov 10, 2020
… (#2583) * Removing some gamma space only code brings bloom closer aligned between linear and gamma colourspaces * Added changelog # Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Brings bloom closer aligned between linear and gamma colourspaces.
Linear colorspace with Bloom:
Gamma colorspace with Bloom Before Fix:
Gamma colorspace with Bloom After Fix:
Testing status
Local testing in Karting template.
Comments to reviewers
Notes for the reviewers you have assigned.