Skip to content

Fix light resolution scalable settings in the Light Explorer #2470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Fix light resolution scalable settings in the Light Explorer #2470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ The version number for this package has increased due to a version update of a r
- Fixed issue with lookdev shadows looking wrong upon exiting playmode.
- Fixed temporary Editor freeze when selecting AOV output in graphics compositor (case 1288744).
- Fixed normal flip with double sided materials.
- Fix shadow resolution settings level in the light explorer.

### Changed
- Combined occlusion meshes into one to reduce draw calls and state changes with XR single-pass.
Expand Down
2 changes: 1 addition & 1 deletion com.unity.render-pipelines.high-definition/Editor/Lighting/HDLightExplorerExtension.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ protected virtual LightingExplorerTableColumn[] GetHDLightColumns()
var shadowResolution = lightData.shadowResolution;

EditorGUI.BeginChangeCheck();
var (level, useOverride) = SerializedScalableSettingValueUI.LevelFieldGUI(r, GUIContent.none, ScalableSettingSchema.GetSchemaOrNull(ScalableSettingSchemaId.With3Levels), shadowResolution.level, shadowResolution.useOverride);
var (level, useOverride) = SerializedScalableSettingValueUI.LevelFieldGUI(r, GUIContent.none, ScalableSettingSchema.GetSchemaOrNull(ScalableSettingSchemaId.With4Levels), shadowResolution.level, shadowResolution.useOverride);
if (EditorGUI.EndChangeCheck())
{
Undo.RecordObject(lightData, "Changed contact shadow resolution");
Expand Down