[Hdrp] Fix issue with linking FoV to physical camera #2407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmavridis
changed the title
| The version number for this package has increased due to a version update of a related graphics package. | ||
|
|
||
| ### Fixed | ||
| - Fixed issue when linking the field of view with the focal length in physical camera |
sebastienlagarde
approved these changes
Oct 27, 2020
Contributor
|
Merging for 10.2 package |
sebastienlagarde
added a commit
that referenced
this pull request
Oct 29, 2020
* Fix linking of the field of view with the focal length in physical camera * Update changelog * Update changelog 2 * Revert small change to make behavior similar to URP * Update changelog - move to 10.2 Co-authored-by: sebastienlagarde <[email protected]>
sebastienlagarde
added a commit
that referenced
this pull request
Oct 30, 2020
This reverts commit aaa9574.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
There is an issue with linking the physical camera FoV with the focal length, discussed in this internal slack thread:
https://unity.slack.com/archives/GHD5LADU7/p1603794331473300
(see also the video from Pierre regarding the issue)
Testing status