Skip to content

[10.x.x] Fixed mirror view shader reading wrong viewport region from the eye textures #2283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thomas-zeng wants to merge 3 commits into from
Closed

[10.x.x] Fixed mirror view shader reading wrong viewport region from the eye textures #2283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
53b2082
Fixed mirror view shader reading wrong viewport region from the eye t…
thomas-zeng Oct 19, 2020
d9b0581
Merge branch 'master' of https://github.com/Unity-Technologies/Graphi…
thomas-zeng Oct 22, 2020
4168f84
Fixed typo.
thomas-zeng Oct 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.universal/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ The version number for this package has increased due to a version update of a r
### Fixed
- Fixed the Unlit shader not being SRP Batcher compatible on OpenGLES/OpenGLCore. [case 1263720](https://issuetracker.unity3d.com/issues/urp-mobile-srp-batcher-is-not-visible-on-mobile-devices-in-frame-debugger)
- Fixed an issue with soft particles not rendering correctly for overlay cameras with post processing. [case 1241626](https://issuetracker.unity3d.com/issues/soft-particles-does-not-fade-out-near-the-opaque-surfaces-when-post-processing-is-enabled-on-a-stacked-camera)
- Fixed latest mockHMD renderviewport scale doesn't fill whole view after scaling. [case 1286161] (https://issuetracker.unity3d.com/issues/xr-urp-renderviewportscale-doesnt-fill-whole-view-after-scaling)

## [10.1.0] - 2020-10-12
### Added
Expand Down
5 changes: 5 additions & 0 deletions com.unity.render-pipelines.universal/Shaders/XR/XRMirrorView.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ Varyings VertQuad(Attributes input)
Varyings output;
output.positionCS = GetQuadVertexPosition(input.vertexID) * float4(_ScaleBiasRt.x, _ScaleBiasRt.y, 1, 1) + float4(_ScaleBiasRt.z, _ScaleBiasRt.w, 0, 0);
output.positionCS.xy = output.positionCS.xy * float2(2.0f, -2.0f) + float2(-1.0f, 1.0f); //convert to -1..1

#if UNITY_UV_STARTS_AT_TOP
// Unity viewport convention is bottom left as origin. Adjust Scalebias to read the correct region.
_ScaleBias.w = 1 - _ScaleBias.w - _ScaleBias.y;
#endif
output.texcoord = GetQuadTexCoord(input.vertexID) * _ScaleBias.xy + _ScaleBias.zw;
return output;
}
Expand Down