[10.x.x] Add --timeout flag to iOS URP jobs #2128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomzig16
changed the title
kivistikliis
approved these changes
Oct 9, 2020
manuele-bonanno
pushed a commit
that referenced
this pull request
Oct 9, 2020
* Add timeout flag for iPhone tests * Run build.py to update iOS runners with timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR adds
--timeoutflag for iPhone players.Recently we saw couple of failures on 2020.2 and master branches that were timed out. Moreover, on a custom branch where I was working with enabling and fixing disabled tests builders were failing due to time out even if only 3 new tests were enabled. This PR fixes that issue.
Testing status
Custom branch with additional 3, 5 and all filtered out tests enabled back (adding timeout fixed the failures on Build job)
Yamato tests: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/urp%252Fios%252Fadd-timeout
Comments to reviewers
iOS failures on trunk are due to 120-122 scenes which is known cross platform issue