Skip to content

Conversation

@Nzollner
Copy link
Contributor

@Nzollner Nzollner commented Apr 6, 2020

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?
The shader quality solves the problem of creating some predefined tiers for the shader to work with without being platform specific if the user want to change the tier on fx. mobiles.
I'm also adding shadow fading which uses the shader tiers to set which tier should allow shadow fading. The shadow fading is implemented to gradually fade out the shadows such that the user don't see a hard line where there is and isn't any shadow.


Testing status

I build a game example with an empty shader cache to see if the stripping made the shader cache smaller if shader qualities were left out and also checked if the other qualities than the starting quality worked correctly to make sure there weren't any unintentional stripping that occurred.
I have added the test 131_ShadowFading

Manual Tests: What did you do?

  • Opened test project + Run graphic tests locally
  • Built a player
  • Checked new UI names with UX convention
  • Tested UI multi-edition + Undo/Redo + Prefab overrides + Alignment in Preset
  • C# and shader warnings (supress shader cache to see them)
  • Checked new resources path for the reloader (in developer mode, you have a button at end of resources that check the paths)
  • Other:

Automated Tests: What did you setup? (Add a screenshot or the reference image of the test please)

Yamato: (Select your branch):
https://yamato.prd.cds.internal.unity3d.com/jobs/78-ScriptableRenderPipeline

Any test projects to go with this to help reviewers?


Comments to reviewers

Notes for the reviewers you have assigned.

@Nzollner Nzollner requested a review from phi-lira April 6, 2020 15:12
@Nzollner Nzollner marked this pull request as ready for review April 8, 2020 06:51
Copy link
Contributor

@phi-lira phi-lira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add a doc page to explain the quality settings and what are they enabling/disabling.
We also need to do shader stripping based on quality so we avoid doing 3x shaders in most cases.

@phi-lira phi-lira requested a review from ellioman April 8, 2020 12:47
@phi-lira
Copy link
Contributor

phi-lira commented Apr 8, 2020

LGTM. Made minor comments and asked docs/shader stripper.

@Nzollner Nzollner requested review from a team as code owners April 20, 2020 06:38
Copy link
Contributor

@martint-unity martint-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :) That was fast. :)

@ghost ghost self-requested a review April 20, 2020 16:21
@ghost ghost self-requested a review April 20, 2020 17:14
@ellioman ellioman changed the title [9.x.x] Universal/shader quality [10.x.x] Universal/shader quality Jul 6, 2020
@Nzollner Nzollner marked this pull request as draft August 10, 2020 08:11
@Nzollner Nzollner closed this Sep 11, 2020
@sebastienlagarde sebastienlagarde deleted the universal/shader-quality branch September 1, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants