Remove Decal Property mask generation #1676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrancescoC-unity
requested review from
JulienIgnace-Unity and
sebastienlagarde
|
It appears that you made a non-draft PR! |
JulienIgnace-Unity
approved these changes
Aug 31, 2020
sebastienlagarde
approved these changes
Sep 2, 2020
sebastienlagarde
added a commit
that referenced
this pull request
Sep 3, 2020
This reverts commit 96a28ae.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on console and it is indeed cheaper without it.
Tested: New template, Scene with around 400 decals on screen with varying properties (affecting different things) and scene with around 60. In all cases the version without HTile was faster, in extreme case it was almost 40% faster.
Tried both with fwd and deferred receivers; again, both cases without is faster.
Also as a benefit this remove one discrepancy between console and PC that was source of several bugs in the past.