Skip to content

Fix issue with disc area light editor not updating #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 6, 2020
Merged

Fix issue with disc area light editor not updating #1526

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f682c5d
Don't update legacy shape with HDRP vals for discs
FrancescoC-unity Aug 5, 2020
afa6e4f
Changelog
FrancescoC-unity Aug 5, 2020
d6e9b32
Merge branch 'HDRP/staging' into HDRP/fix-issue-with-disc-radius-not-…
sebastienlagarde Aug 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -761,6 +761,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed CoatMask block appearing when creating lit master node (case 1264632)
- Fixed issue with SceneEV100 debug mode indicator when rescaling the window.
- Fixed issue with PCSS filter being wrong on first frame.
- Fix issue causing the editor field not updating the disc area light radius.

### Changed
- Improve MIP selection for decals on Transparents
Expand Down
4 changes: 3 additions & 1 deletion com.unity.render-pipelines.high-definition/Runtime/Lighting/Light/HDAdditionalLightData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2837,7 +2837,9 @@ void UpdateShapeSize()
shapeHeight = m_ShapeHeight;

#if UNITY_EDITOR
legacyLight.areaSize = new Vector2(shapeWidth, shapeHeight);
// We don't want to update the disc area since their shape is largely handled by builtin.
if (GetLightTypeAndShape() != HDLightTypeAndShape.DiscArea)
legacyLight.areaSize = new Vector2(shapeWidth, shapeHeight);
#endif
}

Expand Down