Fix issue that caused OnEnable probes to marked as rendered even when they were not #1509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrancescoC-unity
requested review from
a team,
fredericv-unity3d and
sebastienlagarde
|
It appears that you made a non-draft PR! |
TomasKiniulis
approved these changes
Aug 5, 2020
Contributor
TomasKiniulis
left a comment
TomasKiniulis
left a comment
There was a problem hiding this comment.
Checked new template Ref Probes with OnEnable, OnDemand, in Scene/Game view with various fade distances, works as expected!
sebastienlagarde
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for https://fogbugz.unity3d.com/f/cases/1262195/
The issue was due to the fact that we called probe.SetIsRendered(m_FrameCount); regardless of whether the render request has been issued or not. As a result, if we an "OnEnable" probe is deemed not visible, the render request is not queued but the probe is marked as rendered, therefore whenever becomes visible it will not be rendered.
This change forces the probe to be set as rendered only if the probe is visible, otherwise we don't mark it as such.
What have I tested: Tried the same scenario as reported in the bug report, tried on a separate map and tried other fade distances than the one indicated in the video.