[HDRP][Compositor] Add tooltips with the full name of compositor properties that otherwi… #1490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmavridis
changed the title
sebastienlagarde
approved these changes
Aug 4, 2020
Contributor
|
No need QA for this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
https://fogbugz.unity3d.com/f/cases/1263590/
The graphics compositor is using the reference names of the shader graph properties as they are defined in the Shader Graph Inspector:
Since the property name set in ShaderGraph can be arbitrarily big, the compositor UI will have to clip it at some point. Note that ShaderGraph also clips the name.
This PR now shows a tooltip with the full name when the user hovers (and waits a bit) over a property name, so he can see the names of properties that don't fit otherwise in the UI.
Testing status
As shown in the screenshots, clipping of large names still occurs, but now we have tooltips displayingthe full name.
However the user should manually put a shorter name.