Skip to content

Conversation

@JulienIgnace-Unity
Copy link
Contributor

Purpose of this PR

Fix an issue where world space UI was not emitted for reflection cameras in HDRP.
This fixes this issue: https://fogbugz.unity3d.com/f/cases/1155022
It needs this Ono PR to work: https://ono.unity3d.com/unity/unity/pull-request/108914/_/graphics/fix-srp-worldui


Testing status

Manual Tests: What did you do?
Tested the provided scene with the fix and it worked fine.

  • Opened test project + Run graphic tests locally
  • Built a player
  • Checked new UI names with UX convention
  • Tested UI multi-edition + Undo/Redo + Prefab overrides + Alignment in Preset
  • C# and shader warnings (supress shader cache to see them)
  • Checked new resources path for the reloader (in developer mode, you have a button at end of resources that check the paths)

…Graphics into HDRP/fix-world-ui

# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md
Copy link
Contributor

@RemyUnity RemyUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, forget this comment

@RemyUnity RemyUnity self-requested a review July 3, 2020 12:03
@sebastienlagarde
Copy link
Contributor

@RemyUnity : Be sure to chek in editor, Playmode and Player. Last time we get this issue the behavior in player was different

@sebastienlagarde sebastienlagarde changed the title Fix an issue where world space UI was not emitted for reflection cameras in HDRP Fix an issue where world space UI was not emitted for reflection cameras in HDRP [Depends on C++] Jul 3, 2020
Copy link
Contributor

@RemyUnity RemyUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check in editor/playmode/runtime, fix confirmed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants