Skip to content

Commit ab25368

Browse files
PaulDemeulenaereGitHub Enterprise
authored andcommitted
[Fix] Disable reset option (#41)
* Disable reset option * Add repro case 1251533
1 parent ecfc936 commit ab25368

File tree

2 files changed

+14
-0
lines changed

2 files changed

+14
-0
lines changed

com.unity.visualeffectgraph/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
104104
- Missing Reset function in VFXPropertyBinder [Case 1219063](https://issuetracker.unity3d.com/product/unity/issues/guid/1219063/)
105105
- Fix issue with strips outputs that could cause too many vertices to be renderered
106106
- SpawnIndex attribute returns correct value in update and outputs contexts
107+
- Disable Reset option in context menu for all VFXObject [Case 1251519](https://issuetracker.unity3d.com/product/unity/issues/guid/1251519/) & [Case 1251533](https://issuetracker.unity3d.com/product/unity/issues/guid/1251533/)
107108

108109
## [7.1.1] - 2019-09-05
109110
### Added

com.unity.visualeffectgraph/Editor/Models/VFXModel.cs

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,19 @@ namespace UnityEditor.VFX
1111
{
1212
class VFXObject : ScriptableObject
1313
{
14+
//Explicitly disable the Reset option on all VFXObject
15+
//Internal Reset() behavior leads to a dandling state in graph object
16+
[MenuItem("CONTEXT/VFXObject/Reset", false)]
17+
public static void DummyReset()
18+
{
19+
}
20+
21+
[MenuItem("CONTEXT/VFXObject/Reset", true)]
22+
static bool ValidateDummyReset()
23+
{
24+
return false;
25+
}
26+
1427
public Action<VFXObject> onModified;
1528
void OnValidate()
1629
{

0 commit comments

Comments
 (0)