#2182 Get rid of annoying popups in Windows 10 #3400
Conversation
|
|
lib/God/ForkMode.js
Outdated
| @@ -93,7 +93,6 @@ module.exports = function ForkMode(God) { | |||
| try { | |||
| var cspr = spawn(command, args, { | |||
| env : pm2_env, | |||
| detached : true, | |||
There was a problem hiding this comment.
do you really need to remove detached here?
There was a problem hiding this comment.
@soyuka I can't make the windowsHide option works with detached: true. Do we actually needs detached to be true here? I maybe mistook something here, but child processes in cluster mode are attached to the daemon process I think.
There was a problem hiding this comment.
@soyuka I tried to reproduce the problem (detached:true with 'windowsHide:true`) to find the real cause, but found something unexpected. I think the console windows may be not caused by this spawn call at all, but something else. I'll do some digging.
|
@soyuka I've found the root cause of the popping up console window while start process in fork mode. It's not the |
|
Great work @toddwong thanks! |
|
Tests failed are once again not linked to your PR, i will merge it when i finished with pmx :) |
|
Thanks, @vmarchaud ! |
|
ping @wallet77 |
|
Yes I restarted builds but we have troubles with Travis. |
Unitech#2182 Get rid of annoying popups in Windows 10
|
Will this work in fork mode? Cluster mode won't run ps1 file in windows. And fork mode still pop up cmd window. |
Works with node v9.4.0 and above.