Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CFG DSL #294

Merged
merged 16 commits into from
Feb 5, 2025
Merged

Add CFG DSL #294

merged 16 commits into from
Feb 5, 2025

Conversation

Lipen
Copy link
Member

@Lipen Lipen commented Jan 29, 2025

This PR adds the abstract and Ets-specific control flow graphs and related infra: program (AST) representation with DSL for manual construction, block-based CFGs, linearization procedures.

@Lipen Lipen requested a review from CaelmBleidd January 29, 2025 15:18
Copy link
Contributor

github-actions bot commented Jan 29, 2025

Lifecycle test results

78 tests  ±0   78 ✅ ±0   1m 26s ⏱️ -1s
 7 suites ±0    0 💤 ±0 
 7 files   ±0    0 ❌ ±0 

Results for commit b75a494. ± Comparison against base commit 4c32465.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 29, 2025

Test results on JDK 19

 71 files  +1   71 suites  +1   4m 37s ⏱️ -8s
625 tests +1  615 ✅ +1  10 💤 ±0  0 ❌ ±0 
695 runs  +1  685 ✅ +1  10 💤 ±0  0 ❌ ±0 

Results for commit b75a494. ± Comparison against base commit 4c32465.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 42.51852% with 388 lines in your changes missing coverage. Please review.

Project coverage is 70.36%. Comparing base (4c32465) to head (b75a494).
Report is 5 commits behind head on neo.

Files with missing lines Patch % Lines
...rc/main/kotlin/org/jacodb/ets/graph/EtsBlockCfg.kt 52.38% 82 Missing and 18 partials ⚠️
...db-ets/src/main/kotlin/org/jacodb/ets/dsl/ToDot.kt 18.44% 81 Missing and 3 partials ⚠️
...ets/src/main/kotlin/org/jacodb/ets/dsl/BlockCfg.kt 51.48% 36 Missing and 13 partials ⚠️
...codb-ets/src/main/kotlin/org/jacodb/ets/dsl/DSL.kt 0.00% 38 Missing ⚠️
...rc/main/kotlin/org/jacodb/ets/dsl/LinearizedCfg.kt 0.00% 32 Missing ⚠️
...c/main/kotlin/org/jacodb/ets/dsl/ProgramBuilder.kt 44.00% 28 Missing ⚠️
...ts/src/main/kotlin/org/jacodb/ets/utils/ViewDot.kt 0.00% 18 Missing ⚠️
...odb-ets/src/main/kotlin/org/jacodb/ets/dsl/Stmt.kt 0.00% 12 Missing ⚠️
...odb-ets/src/main/kotlin/org/jacodb/ets/dsl/Expr.kt 68.18% 7 Missing ⚠️
...-ets/src/main/kotlin/org/jacodb/ets/dsl/Program.kt 74.07% 4 Missing and 3 partials ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff              @@
##                neo     #294      +/-   ##
============================================
- Coverage     71.64%   70.36%   -1.28%     
- Complexity     2448     2471      +23     
============================================
  Files           255      269      +14     
  Lines         14505    15208     +703     
  Branches       2126     2274     +148     
============================================
+ Hits          10392    10701     +309     
- Misses         3224     3577     +353     
- Partials        889      930      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 29, 2025

Test results on JDK 8

 71 files  +1   71 suites  +1   4m 51s ⏱️ +6s
625 tests +1  612 ✅ +1  13 💤 ±0  0 ❌ ±0 
695 runs  +1  682 ✅ +1  13 💤 ±0  0 ❌ ±0 

Results for commit b75a494. ± Comparison against base commit 4c32465.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 29, 2025

Test results on JDK 11

 71 files  +1   71 suites  +1   5m 26s ⏱️ +13s
625 tests +1  617 ✅ +1  8 💤 ±0  0 ❌ ±0 
695 runs  +1  687 ✅ +1  8 💤 ±0  0 ❌ ±0 

Results for commit b75a494. ± Comparison against base commit 4c32465.

♻️ This comment has been updated with latest results.

@Lipen Lipen force-pushed the lipen/cfg-dsl branch 2 times, most recently from 65b0dec to 3f1f4db Compare January 30, 2025 12:07
Copy link
Member

@CaelmBleidd CaelmBleidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lipen Lipen merged commit d03090c into neo Feb 5, 2025
8 of 10 checks passed
@Lipen Lipen deleted the lipen/cfg-dsl branch February 5, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants