gasUsed and gasPrice in a Transaction + fixing id collisions in complex txs or in multiple txs in block + skipping snapshot when the user is null #46
Conversation
|
@benesjan requested minor changes - after that happy to merge this, definitely a useful feature. |
Hello, I removed the comments from the pull request 😌 |
|
Before merging this, is there any reason to have these fields in the snapshot entity? Can we just have them in teh Transaction entity? Happy to merge if we can do that. |
I added them to the Snapshot entity as well because it allowed me to calculate the gas costs of user's positions using 1 request instead of 2 (I need them to compute precise returns). I could first fetch the snapshots and then filter for tx but that is inefficient. But now that I am thinking about it a better solution might be to reference the Transaction entity directly. |
|
Hello, now the gasUsed and gasPrice are only in the Transaction entity. I also added the tx reference to the LiquidityPositionSnapshot because that way I could calculate tx costs of user's position just by requesting the snapshots (I needed that for my project). The graph is currently syncing here and it seems to work fine 😌 . |
benesjan
changed the title
|
Hello @ianlapham, I know that you guys have a lot of work with Uni v3 but it would be useful to have this merged into the official subgraph. The subgraph with the changes will soon be synced here. Everything works as expected and there are no breaking changes. If you look at the subgraph log, it is now handling the null user situation which occurs in the handleBurn handler. Have a good day, Jan |
|
Hey checking this out. One note - is it true that the subgraph started syncing 2 months ago? It may be stalled in that case. |
|
If you look at the logs you will see that the subgraph is still syncing (blocks are being processed). I think the long sync time is simply caused by the hosted service being a bit overloaded and by the huge uniswap volume. |
|
Hello @ianlapham, the subgraph is now fully synced: https://thegraph.com/explorer/subgraph/benesjan/uniswap-v2 |
Hello, I wanted to account for the transaction costs in trades and liquidity provisioning and I was missing the necessary information for that in the subgraph. I think there is no reason to not include this data as it's made readily available by the graph API.
The deployment of the modified version is accessible here.