build: set null environment for PRs #6638
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #6638 +/- ##
===========================================
- Coverage 60.40% 21.19% -39.21%
===========================================
Files 721 707 -14
Lines 21166 20850 -316
Branches 6977 6935 -42
===========================================
- Hits 12785 4419 -8366
- Misses 8304 16415 +8111
+ Partials 77 16 -61
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1 flaky tests on run #11313 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Swap > Swap on main page > swaps ETH for USDC |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
Joci1980
reviewed
Mar 25, 2024
| @@ -17,7 +17,7 @@ jobs: | |||
| lint: | |||
| runs-on: ubuntu-latest | |||
| environment: | |||
| name: ${{ github.ref_name == 'main' && 'notify/test' }} | |||
| name: ${{ github.ref_name == 'main' && 'notify/test' || null }} | |||
| steps: | |||
| - uses: actions/checkout@v3 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses a "ternary" statement to set a null environment for the test.yml workflow.
This is necessary to avoid "temporarily deployed to false" commit comments on the PR, as described in https://github.com/orgs/community/discussions/36919#discussioncomment-4110859.