-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade web3-react, zustand #6090
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Deploying with Cloudflare Pages
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #6090 +/- ##
=======================================
Coverage 13.85% 13.85%
=======================================
Files 411 411
Lines 12801 12801
Branches 4470 4470
=======================================
Hits 1773 1773
Misses 11019 11019
Partials 9 9 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
package.json
Outdated
"@web3-react/coinbase-wallet": "8.1.1-beta.0", | ||
"@web3-react/core": "8.1.1-beta.0", | ||
"@web3-react/eip1193": "8.1.1-beta.0", | ||
"@web3-react/empty": "8.1.1-beta.0", | ||
"@web3-react/gnosis-safe": "8.1.1-beta.0", | ||
"@web3-react/metamask": "8.1.1-beta.0", | ||
"@web3-react/network": "8.1.1-beta.0", | ||
"@web3-react/types": "8.1.1-beta.0", | ||
"@web3-react/url": "8.1.1-beta.0", | ||
"@web3-react/walletconnect": "8.1.1-beta.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just remove these and use the dependencies brought in by @uniswap/widgets? That way they will stay in sync.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that seems a bit too implicit for me... what if we used resolutions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. We're using this directly in this project, so makes sense to have an explicit dependency.
8167432
to
d7db877
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reverts #6085
This time I will upgrade web3-react with a version that has zustand unpinned.