Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade web3-react, zustand #6090

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Conversation

vm
Copy link
Contributor

@vm vm commented Mar 7, 2023

Reverts #6085

This time I will upgrade web3-react with a version that has zustand unpinned.

@vercel
Copy link

vercel bot commented Mar 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
interface ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 7, 2023 at 8:02PM (UTC)

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 7, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d7db877
Status: ✅  Deploy successful!
Preview URL: https://6e8c9022.interface-y3o.pages.dev
Branch Preview URL: https://revert-6085-revert-6077-gnos.interface-y3o.pages.dev

View logs

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c21b937) 13.85% compared to head (d7db877) 13.85%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6090   +/-   ##
=======================================
  Coverage   13.85%   13.85%           
=======================================
  Files         411      411           
  Lines       12801    12801           
  Branches     4470     4470           
=======================================
  Hits         1773     1773           
  Misses      11019    11019           
  Partials        9        9           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

package.json Outdated
Comment on lines 168 to 177
"@web3-react/coinbase-wallet": "8.1.1-beta.0",
"@web3-react/core": "8.1.1-beta.0",
"@web3-react/eip1193": "8.1.1-beta.0",
"@web3-react/empty": "8.1.1-beta.0",
"@web3-react/gnosis-safe": "8.1.1-beta.0",
"@web3-react/metamask": "8.1.1-beta.0",
"@web3-react/network": "8.1.1-beta.0",
"@web3-react/types": "8.1.1-beta.0",
"@web3-react/url": "8.1.1-beta.0",
"@web3-react/walletconnect": "8.1.1-beta.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just remove these and use the dependencies brought in by @uniswap/widgets? That way they will stay in sync.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that seems a bit too implicit for me... what if we used resolutions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. We're using this directly in this project, so makes sense to have an explicit dependency.

@vm vm changed the title fix: Revert "fix: Revert "chore: upgrade web3-react, widgets"" chore: upgrade web3-react, widgets Mar 7, 2023
@vm vm force-pushed the revert-6085-revert-6077-gnosis-fix branch from 8167432 to d7db877 Compare March 7, 2023 19:53
@vm vm changed the title chore: upgrade web3-react, widgets chore: upgrade web3-react, zustand Mar 7, 2023
@vm vm requested a review from grabbou March 7, 2023 19:55
yarn.lock Show resolved Hide resolved
Copy link
Contributor

@grabbou grabbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vm vm merged commit 6225462 into main Mar 7, 2023
@vm vm deleted the revert-6085-revert-6077-gnosis-fix branch March 7, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants