Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop testing on Python 3.8 #2851

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Stop testing on Python 3.8 #2851

merged 1 commit into from
Mar 4, 2024

Conversation

hmpf
Copy link
Contributor

@hmpf hmpf commented Mar 1, 2024

In production we are running on Python 3.7 and 3.9 (soon also to be running on 3.11) so speed up tests by not running them on Python 3.8.

@hmpf hmpf requested a review from lunkwill42 March 1, 2024 09:11
@hmpf hmpf self-assigned this Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.16%. Comparing base (127ce87) to head (9c65722).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2851   +/-   ##
=======================================
  Coverage   57.16%   57.16%           
=======================================
  Files         568      568           
  Lines       41293    41293           
=======================================
  Hits        23607    23607           
  Misses      17686    17686           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 1, 2024

Test results

       9 files         9 suites   7m 27s ⏱️
3 312 tests 3 312 ✔️ 0 💤 0
6 363 runs  6 363 ✔️ 0 💤 0

Results for commit 9c65722.

♻️ This comment has been updated with latest results.

In production we are running on Python 3.7 and 3.9 (soon also to be
running on 3.11) so speed up tests by not running them on Python 3.8.
Copy link

sonarcloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@hmpf hmpf merged commit 45c2149 into Uninett:master Mar 4, 2024
11 checks passed
@hmpf hmpf deleted the drop-python3.8 branch March 4, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants