-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test on python 3.10 #2838
Test on python 3.10 #2838
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good start, but the matrix stuff obviously doesn't work as intended. All the test suites timed out after hanging for 360 minutes, yet they are all marked as successful checks...
2d6603a
to
f05f70d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2838 +/- ##
==========================================
+ Coverage 57.16% 57.18% +0.01%
==========================================
Files 568 568
Lines 41293 41299 +6
==========================================
+ Hits 23607 23615 +8
+ Misses 17686 17684 -2 ☔ View full report in Codecov by Sentry. |
All green on github, tests not yet done locally. |
All green locally. |
7a715a2
to
c80beab
Compare
We should've been testing for Python 3.10 for a long time now, it's time to start!
Can't remember why this restriction was put in there, but it seems it prevents test results from being published when PR's repo is the same as the origin. Also don't understand or remember why the dependabot restriction is in here. Removing that too.
Quality Gate passedIssues Measures |
Small steps: let's run on on 3.10 before we tackle 3.11