Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on python 3.10 #2838

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Test on python 3.10 #2838

merged 3 commits into from
Mar 5, 2024

Conversation

hmpf
Copy link
Contributor

@hmpf hmpf commented Feb 28, 2024

Small steps: let's run on on 3.10 before we tackle 3.11

@hmpf hmpf requested a review from lunkwill42 February 28, 2024 14:04
Copy link

github-actions bot commented Feb 28, 2024

Test results

     12 files       12 suites   11m 37s ⏱️
3 312 tests 3 312 ✔️ 0 💤 0
9 411 runs  9 411 ✔️ 0 💤 0

Results for commit 3d23adb.

♻️ This comment has been updated with latest results.

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good start, but the matrix stuff obviously doesn't work as intended. All the test suites timed out after hanging for 360 minutes, yet they are all marked as successful checks...

requirements/base.txt Outdated Show resolved Hide resolved
@hmpf hmpf force-pushed the test/python3.10 branch 2 times, most recently from 2d6603a to f05f70d Compare February 29, 2024 13:50
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.18%. Comparing base (45c2149) to head (3d23adb).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2838      +/-   ##
==========================================
+ Coverage   57.16%   57.18%   +0.01%     
==========================================
  Files         568      568              
  Lines       41293    41299       +6     
==========================================
+ Hits        23607    23615       +8     
+ Misses      17686    17684       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hmpf hmpf marked this pull request as ready for review February 29, 2024 14:02
@hmpf hmpf requested a review from lunkwill42 February 29, 2024 14:02
@hmpf
Copy link
Contributor Author

hmpf commented Feb 29, 2024

All green on github, tests not yet done locally.

@hmpf
Copy link
Contributor Author

hmpf commented Mar 1, 2024

All green locally.

@hmpf hmpf force-pushed the test/python3.10 branch 3 times, most recently from 7a715a2 to c80beab Compare March 1, 2024 08:50
lunkwill42 and others added 3 commits March 4, 2024 13:39
We should've been testing for Python 3.10 for a long time now, it's
time to start!
Can't remember why this restriction was put in there, but it seems it
prevents test results from being published when PR's repo is the same as
the origin.

Also don't understand or remember why the dependabot restriction is in
here. Removing that too.
Copy link

sonarcloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hmpf hmpf merged commit 3e434bc into Uninett:master Mar 5, 2024
12 checks passed
@hmpf hmpf deleted the test/python3.10 branch March 5, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants