-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up overview/intro docs #2827
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2827 +/- ##
=======================================
Coverage 57.18% 57.18%
=======================================
Files 568 568
Lines 41299 41299
=======================================
Hits 23615 23615
Misses 17684 17684 ☔ View full report in Codecov by Sentry. |
984877b
to
a14d6cb
Compare
This is a big job so you might want to not eat the entire elephant at once! |
Yes, this is why this PR is only about the section overview and intro and I will open new PRs for other sections |
It seems the picture was replaced during the NAV 4.0 facelift, many years ago, but the description in the docs never changed. This is the original screenshot tthe text is actually referring to: https://github.com/Uninett/nav/blob/ac0c1297051a441e44109900963aa477d1769df7/doc/intro/ipdevinfo-switch-display.png A key difference between the old and the new interface are the job statuses that are now shown in the lower right corner of the main ipdevinfo tab. Old versions had only the one "last update" timestamp. Now there are several, one for each configured collection job in I guess the point to get across here is really that you should keep updating the ipdevinfo page until you see job statuses start coming in with timestamps and green lamps (which signify successful job runs), just as the newer screenshot shows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup :)
adfc6dd
to
e61f3c9
Compare
e61f3c9
to
d129aed
Compare
Quality Gate passedIssues Measures |
When working on #2641 I noticed that a lot of things are outdated in the documentation. I am planning on going through it with a fine comb and fix anything that sticks out to me.
Always open for disagreements on my changes.
I also found the line "For now, the key information here is the
Last updated
field of the top-left detail panel." ingetting_started.rst
, while I cannot find such a field in the picture below it. So that would need to be changed, but I don't know to what.