Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up overview/intro docs #2827

Merged
merged 5 commits into from
Mar 5, 2024

Conversation

johannaengland
Copy link
Contributor

When working on #2641 I noticed that a lot of things are outdated in the documentation. I am planning on going through it with a fine comb and fix anything that sticks out to me.

Always open for disagreements on my changes.

I also found the line "For now, the key information here is the Last updated field of the top-left detail panel." in getting_started.rst, while I cannot find such a field in the picture below it. So that would need to be changed, but I don't know to what.

@johannaengland johannaengland added the documentation Related to documentation of NAV label Feb 22, 2024
@johannaengland johannaengland self-assigned this Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.18%. Comparing base (adae194) to head (d129aed).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2827   +/-   ##
=======================================
  Coverage   57.18%   57.18%           
=======================================
  Files         568      568           
  Lines       41299    41299           
=======================================
  Hits        23615    23615           
  Misses      17684    17684           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 22, 2024

Test results

     12 files       12 suites   11m 20s ⏱️
3 312 tests 3 312 ✔️ 0 💤 0
9 411 runs  9 411 ✔️ 0 💤 0

Results for commit d129aed.

♻️ This comment has been updated with latest results.

@johannaengland johannaengland changed the title Clean up docs Clean up overview/intro docs Feb 26, 2024
@hmpf
Copy link
Contributor

hmpf commented Feb 27, 2024

This is a big job so you might want to not eat the entire elephant at once!

@johannaengland
Copy link
Contributor Author

This is a big job so you might want to not eat the entire elephant at once!

Yes, this is why this PR is only about the section overview and intro and I will open new PRs for other sections

doc/intro/getting-started.rst Outdated Show resolved Hide resolved
@johannaengland
Copy link
Contributor Author

Thanks for approving @hmpf and @stveit, but does anyone of you have an answer to the question I asked in the description of the PR?

@lunkwill42
Copy link
Member

I also found the line "For now, the key information here is the Last updated field of the top-left detail panel." in getting_started.rst, while I cannot find such a field in the picture below it. So that would need to be changed, but I don't know to what.

It seems the picture was replaced during the NAV 4.0 facelift, many years ago, but the description in the docs never changed. This is the original screenshot tthe text is actually referring to: https://github.com/Uninett/nav/blob/ac0c1297051a441e44109900963aa477d1769df7/doc/intro/ipdevinfo-switch-display.png

A key difference between the old and the new interface are the job statuses that are now shown in the lower right corner of the main ipdevinfo tab. Old versions had only the one "last update" timestamp. Now there are several, one for each configured collection job in ipdevpoll.conf.

I guess the point to get across here is really that you should keep updating the ipdevinfo page until you see job statuses start coming in with timestamps and green lamps (which signify successful job runs), just as the newer screenshot shows.

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup :)

doc/intro/getting-started.rst Outdated Show resolved Hide resolved
doc/intro/getting-started.rst Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@johannaengland johannaengland merged commit 16d3c1b into Uninett:master Mar 5, 2024
12 checks passed
@johannaengland johannaengland deleted the docs/cleanup branch March 5, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation of NAV
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants