-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for http header X-Frame-Options #2816
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2816 +/- ##
==========================================
+ Coverage 57.15% 57.16% +0.01%
==========================================
Files 568 568
Lines 41282 41293 +11
==========================================
+ Hits 23596 23607 +11
Misses 17686 17686 ☔ View full report in Codecov by Sentry. |
6ceca61
to
9dc665e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me, but this makes we wonder: What is the actual rationale of using the X-Frame-Options
if it has been superseded by CSP policy headers? Just to support ancient browsers?
Ok, but we'll have to merge #2815 first :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to rebase and merge once #2815 is merged.
f1c9bc7
to
6e2d46d
Compare
Support X-Frame-Options with a default of SAMEORIGIN.
6e2d46d
to
5e0c279
Compare
Quality Gate passedIssues Measures |
Closes #2817
Depends on #2815