Initialize variables that are potentially referenced before assignment in maintenance edit() view
#2784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the convoluted logic of the edit() function, multiple variables may be referenced before proper assignment unless they are given a value of `None` first. Unfortunately, at least two such variables were potentially referenced without being initialized first (among other things, causing the crash mentioned in Uninett#2783). This ensures all variables that may remain "unassigned" are initialized to `None` at the start of the function.
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.8.x #2784 +/- ##
==========================================
+ Coverage 57.00% 57.01% +0.01%
==========================================
Files 567 567
Lines 41277 41275 -2
==========================================
+ Hits 23528 23532 +4
+ Misses 17749 17743 -6 ☔ View full report in Codecov by Sentry. |
hmpf
reviewed
Dec 11, 2023
hmpf
approved these changes
Dec 11, 2023
|
Great, good job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the convoluted logic of the edit() function, multiple variables may be referenced before proper assignment unless they are given a value of
Nonefirst.Unfortunately, at least two such variables were potentially referenced without being initialized first.
This ensures all variables that may remain "unassigned" are initialized to
Noneat the start of the function.Fixes #2783