-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch error when adding netbox with non existing profiles #2765
Catch error when adding netbox with non existing profiles #2765
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.8.x #2765 +/- ##
==========================================
+ Coverage 56.16% 56.19% +0.02%
==========================================
Files 567 567
Lines 41277 41279 +2
==========================================
+ Hits 23185 23195 +10
+ Misses 18092 18084 -8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In short, this would normally only happen if fuzzing the form input directly in a manufactured POST request (as when pen-testing), never when posting correctly from the SeedDB netbox form.
Also a good cleanup.
dd2c5b2
to
a2a1890
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still good
Kudos, SonarCloud Quality Gate passed! |
Another things that was discovered by the pentest.