Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch error when adding netbox with non existing profiles #2765

Merged

Conversation

johannaengland
Copy link
Contributor

@johannaengland johannaengland commented Nov 25, 2023

Another things that was discovered by the pentest.

Copy link

codecov bot commented Nov 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cbad667) 56.16% compared to head (dd2c5b2) 56.19%.

❗ Current head dd2c5b2 differs from pull request most recent head a2a1890. Consider uploading reports for the commit a2a1890 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            5.8.x    #2765      +/-   ##
==========================================
+ Coverage   56.16%   56.19%   +0.02%     
==========================================
  Files         567      567              
  Lines       41277    41279       +2     
==========================================
+ Hits        23185    23195      +10     
+ Misses      18092    18084       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Test results

     12 files       12 suites   11m 57s ⏱️
3 292 tests 3 292 ✔️ 0 💤 0
9 351 runs  9 351 ✔️ 0 💤 0

Results for commit dd2c5b2.

lunkwill42
lunkwill42 previously approved these changes Nov 28, 2023
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In short, this would normally only happen if fuzzing the form input directly in a manufactured POST request (as when pen-testing), never when posting correctly from the SeedDB netbox form.

Also a good cleanup.

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still good

Copy link

sonarcloud bot commented Nov 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@lunkwill42 lunkwill42 merged commit 7f19d6f into Uninett:5.8.x Nov 28, 2023
9 checks passed
@johannaengland johannaengland deleted the bugfix/add-ip-device-invalid-profiles branch November 28, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants