-
Notifications
You must be signed in to change notification settings - Fork 441
New theme and organization for docs #1457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Ping @ddirks, if you have even 5-10 minutes to spare on styling or organization, it would be greatly appreciated. We can always revise later, but good to put our best foot forward... |
|
On an initial impression, this looks great! I'd definitely vote in favor of moving to this theme. I've been a fan of it ever since I found out about it at SciPy (particularly since it uses Bootstrap), and it sounds like it was a good motivation for reorganizing the content structure of the docs. I can take a closer look once certain other things are done, but I definitely agree with the to-do items you pointed out. To add to them/go in more detail:
|
|
If anyone is curious about the icons for the cards on the main page, they're from Font Awesome which was already included. Other suggestions welcome. |
|
I love the top nav bar and use of the headlines to help users interact in desirable ways with things related to MetPy (e.g., the survey). Overall I like the big boxes that describe the different areas of the Docs. That will help to get users to the content they need. I largely agree with all of the comments already provided by @jthielen, especially the negative space on the main page and to a lesser extent on the other pages. The left nav bar should probably be smaller, especially on the home page. With all of the negative space, the page is very white and bright, could use a touch more color, even if just the icons associated with the different subpages had a background color associated with them, or something similar. On the main page, would it be possible to have the User Guide and Reference Guide on top, with the Examples and Developer Guide on the bottom? That organization seems more natural to me. Additionally, can the icons also be links? Seems like it would be beneficial to have a larger area that could be clicked on to get to the desired page rather than just the text name within each box. On the GEMPAK Conversion page (The name should maybe be GEMPAK Comparison and Equivalence?) it would be nice to get the full table to appear directly on the page and not have to figure out how to scroll over to get to the actual comparison information cells. Is there an ability to organize or at least add headers to content in the left nav bar on certain pages (e.g., examples and calc pages)? That's all I've got right now...great work, in the end this is a good iteration of the docs! |
d229119 to
bc1ca37
Compare
|
Ok, latest push doesn't do much to content, but:
What remains for the merge on this I think is taking a pass through making the re-organization of content better. I don't want to hold this up for some of the sidebar and other theming/styling issues--we can handle those going forward. I'll make a pass through content next. |
bc1ca37 to
ef645a7
Compare
|
Not sure how relevant this is given the current timeline of the release, but the xarray repr issue I mentioned earlier with this theme is fixed on master (pydata/pydata-sphinx-theme#274), but not yet released. Right now I think this only breaks the isentropic interpolation example with the dataset being missing (examples/isentropic_example.html), but I'm not sure where else we were relying on the xarray HTML repr yet. |
ea7d2f9 to
f3d292f
Compare
When using the plot extension, the default is to make images as PNG, hires PNG, and PDF. Limit to just the PNG.
This is a nice, clean bootstrap-based theme that is used by quite a few projects in the pydata ecosystem.
Put clean back to only removing sphinx built docs and add a `cleanall` target to remove the output from sphinx-gallery. This allows a make clean to be a bit quicker when working on doc theming/style.
Use f-strings and clean up version/release parsing code.
This requires tweaking the theme to add some elements, plus a version of our previous javascript to populate it based on json in the root of the docs repo.
Our previous set of top-level content headings and organization was not well-suited to the top navbar.
This handles serving docs out of build/html and also does some path manipulation to serve our test version of the news alert and versions.json.
We have 4 main cards on the landing page: user guide, examples, reference guide, and developer's guide. Reorganize the content from the main page into those spots.
We can remove manually installing our patched theme now.
This should help Google search only show the latest docs.
Adds some color and also drastically improves alignment of elements across the cards.
Running the linkchecker ends up with second build of the docs, which causes warnings and chokes due to finding vendored LICENSE.md files in the build directory.
d513bc2 to
5b47012
Compare
|
This pull request introduces 1 alert when merging 5b47012 into 49e041d - view on LGTM.com new alerts:
|
|
CSS border/color changes talked about on telecon:
|
|
@dopplershift would you be able to add this css with the xarray override? .xr-var-data pre {
border: none;
box-shadow: none;
} |
Start taking bits and pieces from within the user guide (getting start, install, etc.) and putting them where they make more sense.
5b47012 to
4c305f2
Compare
|
This pull request introduces 1 alert when merging 4c305f2 into 49e041d - view on LGTM.com new alerts:
|
Finally figured out how this works.
4c305f2 to
9adc91e
Compare
|
This pull request introduces 1 alert when merging 9adc91e into 49e041d - view on LGTM.com new alerts:
|
Allow controlling theming in the renamed banner.html file. Also tweak the theme for the notice about the version.
c686551 to
94751ff
Compare
|
Everyone was happy with how this looks on the call, so now that we're green (except for Code Climate for some reason) in it goes... |
Description Of Changes
In my never-ending quest to
rearrange the deck chairs on the Titanicfind new infrastructure improvements for MetPy, I stumbled across the pydata-sphinx-theme, which is used to power Pandas' docs among other projects. I was inspired and decided to try applying the theme to our docs.The initial port made clear we had too many top-level topics, so it led to a further hack-and-slash re-organization that left us with 4 main top-level headings: User Guide, Examples, Reference Guide, and Developer's Guide; there's also a link at the top to our support resources, as well as external links to the Python Training gallery and our GitHub releases. Altogether, this re-org starts to address #1041, #1351, and #1445. The result is:
You can view the new site here as well.
Gains:
gh-pagesbranch--making it appear on all the docs with this themeStill todo:
canonical_urlin generated HTML--something we had with RTD that helps Google, etc. prefer our /latest docs.Also, my sphinx, as well as bootstrap+CSS, fu has increased in doing this so lots of things are relatively possible. For instance, inserting the version controller was not a huge deal (though I do want to upstream some changes so I don't have to override the entire navbar HTML file just to add it).
I'm open to any and all feedback on styling, structure, and content organization.
Credit goes to Bokeh's docs for the banner idea and help on how to do the version chooser. Pandas showed how to achieve the front page cards.
Checklist