Fix quantified/units-on-attribute mixtures in tests and derivative calculations for xarray 0.16.0 #1431
Conversation
Bumps [xarray](https://github.com/pydata/xarray) from 0.15.1 to 0.16.0. - [Release notes](https://github.com/pydata/xarray/releases) - [Changelog](https://github.com/pydata/xarray/blob/master/HOW_TO_RELEASE.md) - [Commits](pydata/xarray@v0.15.1...v0.16.0) Signed-off-by: dependabot[bot] <[email protected]>
jthielen
added
Type: Maintenance
|
|
|
Looks like CLA is hung up because dependabot is the author of the commit. No worries, but for ease in the future might be easier to just duplicate the change. Does this really belong in 0.12.2? I guess I just wasn't expecting unit-containing behavior to work on 0.12.2. |
dopplershift
left a comment
dopplershift
left a comment
There was a problem hiding this comment.
Regardless of whether this goes on 0.12.2, this looks good and can certainly merge to master.
|
I think coverage is slightly down because we removed covered lines. |
|
@dopplershift I tagged it as 0.12.2 based on your comment here #1419 (comment), but yes, I think this is more based on 1.0 features so may be more appropriate there. I'm not sure where or how these changes affect the 0.12.x branch. And that sounds good about just duplicating the version bump in the future rather than incorporating dependabot's commit. |
|
Ah, now I understand. Ok, we can leave it, then I'll see if I need to cherry-pick the code change to actually get tests to pass on the 0.12.x branch. |
|
For the record, the only change from this PR in 0.12.2 is the change to allow xarray 0.16.0 for CI. No code changes needed on the 0.12.x branch. |
3 participants
Description Of Changes
Fix some mixing of quantified and units-on-attribute DataArrays which breaks
xr.testing.assert_allclosein xarray 0.16.0. This allows us to bump the current CI build to xarray 0.16.0.Checklist
addedupdated