added albers_conical_equal_area projection #1344
Conversation
|
@dopplershift , to implement albers, I just copied the code for the lambert method and test. I figured they were both conformal, so the parameters should be the same? Of course there may be more to it than that, but fingers crossed! 😸 |
dopplershift
left a comment
dopplershift
left a comment
There was a problem hiding this comment.
The code looks good in general. Just a few minor flake8 issues.
dopplershift
left a comment
dopplershift
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
dopplershift
added
Area: Projections
| attrs = {'grid_mapping_name': 'albers_conical_equal_area', 'standard_parallel': 25} | ||
| crs = CFProjection(attrs).to_cartopy() | ||
| assert isinstance(crs, ccrs.AlbersEqualArea) | ||
| assert crs.proj4_params['lat_1'] == 20 |
There was a problem hiding this comment.
This does not seem to match with the attrs that was set (attrs says 25, this says 20), which is causing test suite to now fail after the fixes I'm working on in #1325. @dopplershift Can I update it there to get tests passing?
There was a problem hiding this comment.
sigh Yes. This is why we need CI working, because I suck at code review.
3 participants
Description Of Changes