Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Universal property of fibers #944

Merged
merged 40 commits into from
Dec 5, 2023
Merged

Universal property of fibers #944

merged 40 commits into from
Dec 5, 2023

Conversation

morphismz
Copy link
Contributor

This pr formalizes the universal property of fibers of maps. This is part of issue #702 on the Hopf fibration.

@fredrik-bakke fredrik-bakke changed the title universal property of fibers Universal property of fibers Dec 1, 2023
@morphismz
Copy link
Contributor Author

@fredrik-bakke Sorry for not making those formatting changes yet. I forgot to get around to it. I believe @EgbertRijke is planning on making some changes to this pr on his end (to help with the cyclicity of modules). Not sure if hes started that yet or not, but don't want to cause a merge conflict when he tries to push those changes. Thus I may wait until he has finished those changes before I make more edits to this pr.

@EgbertRijke
Copy link
Collaborator

@fredrik-bakke Sorry for not making those formatting changes yet. I forgot to get around to it. I believe @EgbertRijke is planning on making some changes to this pr on his end (to help with the cyclicity of modules). Not sure if hes started that yet or not, but don't want to cause a merge conflict when he tries to push those changes. Thus I may wait until he has finished those changes before I make more edits to this pr.

I'm on it. When I'm ready I will make a pull request to your branch, which you can then merge so that it will become part of your PR.

@EgbertRijke
Copy link
Collaborator

Raymond, give us the green light when you're happy with the pull request.

@morphismz
Copy link
Contributor Author

Raymond, give us the green light when you're happy with the pull request.

Looks great to me! I think its ready to merge

@EgbertRijke EgbertRijke merged commit dcc67bb into UniMath:master Dec 5, 2023
4 checks passed
@morphismz morphismz deleted the universal-property-of-fibers branch December 5, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrik-bakke fredrik-bakke fredrik-bakke left review comments

@EgbertRijke EgbertRijke EgbertRijke left review comments

Assignees
No one assigned
Labels
foundation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@morphismz @EgbertRijke @fredrik-bakke