Refactor category theory to use strictly involutive identity types #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-families-of-sets`
|
This one's ready for review :) Don't get fooled by the similar number of additions and deletions, many of them are disjoint. |
|
My next planned refactoring (of finite types) depends on this PR, so has to wait until this one has been merged. |
What do you want to do with finite types? |
|
I want to change how the symbol |
EgbertRijke
approved these changes
Mar 11, 2024
src/category-theory/composition-operations-on-binary-families-of-sets.lagda.md
Outdated
Show resolved
Hide resolved
src/category-theory/composition-operations-on-binary-families-of-sets.lagda.md
Outdated
Show resolved
Hide resolved
src/category-theory/composition-operations-on-binary-families-of-sets.lagda.md
Outdated
Show resolved
Hide resolved
src/category-theory/composition-operations-on-binary-families-of-sets.lagda.md
Outdated
Show resolved
Hide resolved
…of-sets.lagda.md Co-authored-by: Egbert Rijke <[email protected]>
…of-sets.lagda.md Co-authored-by: Egbert Rijke <[email protected]>
…of-sets.lagda.md Co-authored-by: Egbert Rijke <[email protected]>
Co-authored-by: Egbert Rijke <[email protected]>
Co-authored-by: Egbert Rijke <[email protected]>
Co-authored-by: Egbert Rijke <[email protected]>
Co-authored-by: Egbert Rijke <[email protected]>
|
Thanks for the suggestions! |
|
This PR can be merged when you're done with the comments. |
|
Great, thanks |
fredrik-bakke
added a commit
to fredrik-bakke/agda-unimath
that referenced
this pull request
Mar 14, 2024
…niMath#1052) ### Summary - Refactors the definition of categories to use the new and more general strictly involutive identity types for their associativity witnesses. - Refactor definitions of some instances of large and small precategories to use a new `make-(Large-)?-Precategory` constructor. - Defines the underlying large precategory of a large subprecategory. - Change some prose regarding basic definitions in category theory. - Refactors all appropriate instances of large precategories to be (full) large subprecategories. - Rename `is-group` to `is-group-Semigroup`. The last item was appropriate to make the handling of `involutive-eq-associative-comp-hom-***-Large-Precategory` systematic. Improves on what was implemented in UniMath#945.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
make-(Large-)?-Precategoryconstructor.is-grouptois-group-Semigroup.The last item was appropriate to make the handling of
involutive-eq-associative-comp-hom-***-Large-Precategorysystematic.Improves on what was implemented in #945.