Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CLI warnings #911

Merged
merged 1 commit into from
May 15, 2022
Merged

Fix CLI warnings #911

merged 1 commit into from
May 15, 2022

Conversation

Miepee
Copy link
Contributor

@Miepee Miepee commented May 13, 2022

Description

This fixes almost all warnings related to UMTCli.
It does so by fixing typos, fixing the naming scheme, disabling Nullable types (as no other projects use them, and CLI never used those in the first place) and disabling warnings for CommandOptions (as those get assigned via reflection)

Caveats

None

@Miepee Miepee marked this pull request as draft May 13, 2022 12:06
@Miepee Miepee marked this pull request as ready for review May 13, 2022 12:10
@Miepee Miepee force-pushed the consoleWarnings branch 2 times, most recently from 61d2dcb to ca79dbb Compare May 13, 2022 12:11
@Grossley Grossley merged commit 6362878 into UnderminersTeam:master May 15, 2022
@Miepee Miepee deleted the consoleWarnings branch June 16, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants