Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of custom Tuple class #881

Merged
merged 1 commit into from
May 5, 2022
Merged

Conversation

Miepee
Copy link
Contributor

@Miepee Miepee commented May 1, 2022

There currently is a class called Pair which is just a custom tuple class.
I did some benchmarking (decompile every code entry in AM2R), and found out that there is no speed difference nor memory usage between using Pair, ValueTuple or Tuple.
Tuple:
image
ValueTuple:
image
Pair:
image

For the sake of simplicity, I chose to replace it with a ValueTuple instead.

@Grossley Grossley merged commit ce428d2 into UnderminersTeam:master May 5, 2022
@Miepee Miepee deleted the pair branch May 8, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants