Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Per-tab history. #1003

Merged
merged 6 commits into from
Jun 26, 2022
Merged

Per-tab history. #1003

merged 6 commits into from
Jun 26, 2022

Conversation

VladiStep
Copy link
Member

@VladiStep VladiStep commented Jun 25, 2022 •
edited
Loading

Description

  1. Tab history is now stored per-tab.
  2. Tab history can be navigated through in both directions - added "Forward" button; back and forward mouse buttons work.
  3. Tab.OpenedObject is renamed to Tab.CurrentObject.
  4. Added MainWindow.OnPropertyChanged().
  5. Fixed object re-opening after closing all tabs with "Close all tabs".
  6. Fixed bug that in some cases broke the tab close button after closing other tabs with "Close other tabs".
  7. "Open in new tab" option always opens a object in a new tab.
  8. Asset items do always open in the current tab on double-click.
  9. ChangeSelection() (used by UndertaleObjectReference and more) opens an object in the current tab.
  10. The history navigation button(s) icon opacity is reduced.

Notes

The last sub-issue of #827 can be closed.

VladiStep added 4 commits June 24, 2022 22:23
@VladiStep
Initial per-tab history changes.
5f27ac4 
1) Tab history is stored per tab
2) "OpenedObject" renamed to "CurrentObject"
3) Added "MainWindow.OnPropertyChanged()"
4) Fixed object re-opening after "Close all tabs"
5) Fixed bug that broke tab close button sometimes after "Close other tabs"
6) "Open in new tab" always opens object in a new tab
@VladiStep
Implemented going forward within the tab history; back/forward mouse …
da8e52e 
…buttons navigate through the history
@VladiStep
Added "Forward" UI button
2b7acac
@VladiStep
Fixed tab title updating
7361c80
@github-actions
Copy link

github-actions bot commented Jun 25, 2022 •
edited
Loading

Download the artifacts for this pull request here:

GUI:

CLI:

Miepee
Miepee reviewed Jun 26, 2022
View reviewed changes
UndertaleModTool/MainWindow.xaml.cs Show resolved Hide resolved
UndertaleModTool/MainWindow.xaml.cs Outdated Show resolved Hide resolved
UndertaleModTool/MainWindow.xaml.cs Outdated Show resolved Hide resolved
UndertaleModTool/MainWindow.xaml.cs Show resolved Hide resolved
@Miepee
Copy link
Contributor

Miepee commented Jun 26, 2022

Some notes while testing:

  • maybe make the buttons in full greyscale, to better show that they're disabled?
  • pretty sure we had this discussion before and realize i'm wrong, but IMO now that i toy around with it, I feel like when something should get opened in the current tab, it should always do that, and do not switch to earlier occurences of the same object

@VladiStep
Copy link
Member Author

VladiStep commented Jun 26, 2022 •
edited
Loading

  • maybe make the buttons in full greyscale, to better show that they're disabled?

I've tried that by adding FormatConvertedBitmap with DestinationFormat="Gray8" as a resource (so it won't be recreated on each button disable), but that doesn't work.
So I'll just reduce the opacity to 0.2 - this also seems to work.

@VladiStep
Tab behavior changes, and some fixes
97f97b2 
1) Asset item always opens in the current tab on double-click.
2) "ChangeSelection()" opens an object in the current tab.
3) Fixed tab history after deleting an item: consecutive duplicates removing, history position shifting.
4) Fixed the object ID label updating on the same tab.
@Miepee
Copy link
Contributor

Miepee commented Jun 26, 2022

You missed the opacity for the second arrow
image

Miepee
Miepee approved these changes Jun 26, 2022
View reviewed changes
Copy link
Contributor

@Miepee Miepee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the few small issues here and there, this was done surprisingly quick!

@Grossley Grossley merged commit 3d9fc2e into UnderminersTeam:master Jun 26, 2022
@VladiStep VladiStep deleted the perTabHistory branch June 27, 2022 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miepee Miepee Miepee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VladiStep @Miepee @Grossley