Allow 'disableSelection' to be disabled #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UndefinedOffset
added a commit
that referenced
this pull request
Apr 7, 2015
Allow 'disableSelection' to be disabled
|
thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently disableSelection is always enabled.
This is useful for the drap/drop function, however in firefox this disables the ability to use GridfieldEditableColumns as you cannot focus the inputs.
This pull request allows you to either pass
falseas the second parameter to the constructor - or use->setDisableSelection(false)to disable the disableSelection() call.I had considered changing the behaviour so
disableSelection()is called when you enable drag/drop andenableSelection()is called when you disable drag/drop but this still produces inconsistent results across browsers.This change is 100% backwards compatible as the default is to enable
disableSelection()