[World] Small performance improvement.

Unarelith · May 8, 2023 · 91f3883 · 91f3883
1 parent 390ff5e
commit 91f3883
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 17 deletions.
diff --git a/source/common/world/World.cpp b/source/common/world/World.cpp
@@ -116,6 +116,24 @@ void World::setData(int x, int y, int z, u16 data) const {
 		chunk->setData(x & (CHUNK_WIDTH - 1), y & (CHUNK_DEPTH - 1), z & (CHUNK_HEIGHT - 1), data);
 }
 
+bool World::addChunkToUpdate(Chunk *chunk) {
+	if (m_chunksToUpdate.find(chunk) == m_chunksToUpdate.end()) {
+		m_chunksToUpdate.emplace(chunk);
+		m_chunkUpdateQueue.emplace(chunk);
+		return true;
+	}
+	return false;
+}
+
+bool World::addChunkToProcess(Chunk *chunk) {
+	if (m_chunksToProcess.find(chunk) == m_chunksToProcess.end()) {
+		m_chunksToProcess.emplace(chunk);
+		m_chunkProcessQueue.emplace(chunk);
+		return true;
+	}
+	return false;
+}
+
 void World::clearUpdateQueues() {
 	while (!m_chunkUpdateQueue.empty())
 		m_chunkUpdateQueue.pop();

diff --git a/source/common/world/World.hpp b/source/common/world/World.hpp
@@ -52,23 +52,8 @@ class World {
 		u16 getData(int x, int y, int z) const;
 		void setData(int x, int y, int z, u16 data) const;
 
-		bool addChunkToUpdate(Chunk *chunk) {
-			if (m_chunksToUpdate.count(chunk) < 1) {
-				m_chunksToUpdate.emplace(chunk);
-				m_chunkUpdateQueue.emplace(chunk);
-				return true;
-			}
-			return false;
-		}
-
-		bool addChunkToProcess(Chunk *chunk) {
-			if (m_chunksToProcess.count(chunk) < 1) {
-				m_chunksToProcess.emplace(chunk);
-				m_chunkProcessQueue.emplace(chunk);
-				return true;
-			}
-			return false;
-		}
+		bool addChunkToUpdate(Chunk *chunk);
+		bool addChunkToProcess(Chunk *chunk);
 
 		virtual void onBlockPlaced(int, int, int, const Block &) {}